S927 FP fix: Fix cases when generic type arguments are changed #5241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return true; | ||
| } | ||
| } | ||
| return false; |
There was a problem hiding this comment.
This line should not be needed.
| { | ||
| context.ReportIssue(Diagnostic.Create(rule, parameter.GetLocation(), parameter.ValueText, expectedParameter.Name, expectedLocation)); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private static bool AreGenericWithDifferentTypes(ITypeSymbol actualType, ITypeSymbol expectedType) |
There was a problem hiding this comment.
I would change this name to something like AreGenericTypeParametersWithDifferentTypes. To be a bit more clear what the method does.
WDYT?
| if (actualType is INamedTypeSymbol actualNamedType | ||
| && expectedType is INamedTypeSymbol expectedNamedType) | ||
| { | ||
| for (var i = 0; i < actualNamedType.TypeArguments.Count(); i++) |
There was a problem hiding this comment.
For readability maybe extract lines 109-115 in a different method?
mary-georgiou-sonarsource
requested changes
Jan 5, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4370