Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule S4823: check also top level statements #5129

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Rule S4823: check also top level statements #5129

merged 1 commit into from
Dec 2, 2021

Conversation

costin-zaharia-sonarsource
Copy link
Member

No description provided.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2021 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@costin-zaharia-sonarsource costin-zaharia-sonarsource marked this pull request as ready for review December 1, 2021 16:18
dmitry-golovinov-sonarsource
dmitry-golovinov-sonarsource approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, nice refactoring!

analyzers/src/SonarAnalyzer.CSharp/Trackers/CSharpMethodDeclarationTracker.cs Show resolved Hide resolved
mary-georgiou-sonarsource
mary-georgiou-sonarsource approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Nice refactoring!

@mary-georgiou-sonarsource mary-georgiou-sonarsource merged commit eefb505 into master Dec 2, 2021
@mary-georgiou-sonarsource mary-georgiou-sonarsource deleted the costin/S4823 branch December 2, 2021 12:04
@costin-zaharia-sonarsource costin-zaharia-sonarsource added this to the 8.33 milestone Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitry-golovinov-sonarsource dmitry-golovinov-sonarsource dmitry-golovinov-sonarsource approved these changes

@mary-georgiou-sonarsource mary-georgiou-sonarsource mary-georgiou-sonarsource approved these changes

Assignees

@costin-zaharia-sonarsource costin-zaharia-sonarsource

Labels
None yet
Projects
None yet
Milestone
8.33
Development

Successfully merging this pull request may close these issues.
3 participants
@costin-zaharia-sonarsource @dmitry-golovinov-sonarsource @mary-georgiou-sonarsource