Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule S1186: check also the local functions #5085

Merged
merged 3 commits into from
Nov 24, 2021
Merged

Rule S1186: check also the local functions #5085

merged 3 commits into from
Nov 24, 2021

Conversation

costin-zaharia-sonarsource
Copy link
Member

No description provided.

@costin-zaharia-sonarsource costin-zaharia-sonarsource added this to the 8.33 milestone Nov 23, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.3% 95.3% Coverage
0.0% 0.0% Duplication

mary-georgiou-sonarsource
mary-georgiou-sonarsource approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;
I'd add one test for this to increase coverage.

@costin-zaharia-sonarsource
Copy link
Member Author

I'd add one test for this to increase coverage.

Do you see a specific case that is not covered?

@costin-zaharia-sonarsource costin-zaharia-sonarsource merged commit dac4096 into master Nov 24, 2021
@costin-zaharia-sonarsource costin-zaharia-sonarsource deleted the costin/S1186 branch November 24, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mary-georgiou-sonarsource mary-georgiou-sonarsource mary-georgiou-sonarsource approved these changes

Assignees

@costin-zaharia-sonarsource costin-zaharia-sonarsource

Labels
None yet
Projects
None yet
Milestone
8.33
Development

Successfully merging this pull request may close these issues.
2 participants
@costin-zaharia-sonarsource @mary-georgiou-sonarsource