Rule S1144: remove duplicate issues in top level statements #5081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costin-zaharia-sonarsource
assigned mary-georgiou-sonarsource and unassigned costin-zaharia-sonarsource
costin-zaharia-sonarsource
force-pushed
the
costin/S1144
branch
from
3095c43 to
e3f95d8
Compare
costin-zaharia-sonarsource
assigned costin-zaharia-sonarsource and unassigned mary-georgiou-sonarsource
costin-zaharia-sonarsource
force-pushed
the
costin/S1144
branch
from
7920cbd to
c729f64
Compare
costin-zaharia-sonarsource
requested a review
from mary-georgiou-sonarsource
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned costin-zaharia-sonarsource
| // We cannot tell for sure, but in this case we prefer to have FNs instead of FPs, considering that there is a low chance to have | ||
| // a program class in the global namespace. | ||
| symbol.Name == "Program" | ||
| && symbol.ContainingNamespace.IsGlobalNamespace; |
There was a problem hiding this comment.
analyzers/src/SonarAnalyzer.CSharp/Rules/UnusedPrivateMember.cs
Outdated
Show resolved
Hide resolved
mary-georgiou-sonarsource
requested changes
Nov 23, 2021
github-actions
bot
assigned costin-zaharia-sonarsource and unassigned mary-georgiou-sonarsource
- the symbols were processed twice, once for the Program symbol and the second time for the types defined in the top level statement file.
costin-zaharia-sonarsource
force-pushed
the
costin/S1144
branch
from
c729f64 to
36a11bd
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
costin-zaharia-sonarsource
requested a review
from mary-georgiou-sonarsource
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned costin-zaharia-sonarsource
github-actions
bot
assigned costin-zaharia-sonarsource and unassigned mary-georgiou-sonarsource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The symbols were processed twice, once for the Program symbol and the second time for the types defined in the top-level statement file.