Additional cases where uses of integers are clearly not magic #4625
Conversation
|
An additional possible case is present in https://referencesource.microsoft.com/#system.web/Security/SQLMembershipProvider.cs,1039 I had been porting some of this to .net core and because the stored procedure returns a selection of variables, the resulting field names in the SqlDataReader are all |
There was a problem hiding this comment.
Thanks @StingyJack
We've discussed internally and created an issue with the cases we'd like to cover: #4737
| /// <summary> | ||
| /// A five minute sliding expiration | ||
| /// </summary> | ||
| public static CacheItemPolicy FiveMinSlide => new CacheItemPolicy {SlidingExpiration = new TimeSpan(0, 5, 0)}; |
There was a problem hiding this comment.
indeed DateTime APIs could be considered as well-known cases. The problem is how to avoid having to maintain such a list, we would need to find something generic enough.
There was a problem hiding this comment.
if parameter name is the name of a specific time measurement ("day" "month" "year", etc), then the usage of a literal has an obvious, specific, and easy to understand meaning and is thus not "magic".
There was a problem hiding this comment.
The same would be true for "Order"
There was a problem hiding this comment.
May be first go back to the drawing board, and think of what to support first?
There was a problem hiding this comment.
@Corniel as a user of sonarcloud, I want it to report when a literal number has been used in a place where its not obvious what that number's meaning is.
There was a problem hiding this comment.
@StingyJack I got that point. This a pull request. I saw that @andrei-epure-sonarsource already made an issue to discuss the fllow up: #4737
There was a problem hiding this comment.
Then I'm not sure what you're looking for here from me
There was a problem hiding this comment.
@StingyJack Well, I'm just a volunteer, but I would think that your input on what should not be considered magical numbers would help. As @andrei-epure-sonarsource andrei-epure-sonarsource mentioned, the challenge is to come with generic constraints, instead of some types that should be excluded, as the maintenance cost is high for those.
There was a problem hiding this comment.
I initially asked for a PR with test cases on the community forum, hence this PR.
I will close this PR in favor of #4737.
Thanks @StingyJack for the discussion and this PR.
|
I will close this PR in favor of #4737. |
Per request https://community.sonarsource.com/t/s109-magic-numbers-on-attributes/15784/15
@csaba-sagi-sonarsource