Fix S4529: Should not highlight constructors, properties and methods with NonActionAttribute #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
valhristov
changed the title
…with NonActionAttribute
valhristov
force-pushed
the
val/fix-endpoints
branch
from
0cb5f00 to
148f20b
Compare
valhristov
changed the title
valhristov
changed the title
Evangelink
reviewed
Nov 19, 2018
| ); | ||
| KnownType.System_Web_Mvc_Controller); | ||
|
|
||
| private static readonly ImmutableArray<KnownType> nonactionTypes = |
There was a problem hiding this comment.
[minor] The a should be uppercase (i.e. nonActionTypes)
| @@ -44,6 +49,8 @@ public static class AspNetMvcHelper | |||
| /// </summary> | |||
| public static bool IsControllerMethod(this IMethodSymbol methodSymbol) => | |||
| methodSymbol.GetEffectiveAccessibility() == Accessibility.Public && | |||
| methodSymbol.MethodKind == MethodKind.Ordinary && | |||
There was a problem hiding this comment.
I would put this line before the effective accessibility check as it is simpler (faster).
| } | ||
|
|
||
| [DataTestMethod] | ||
| [DataRow("3.0.20105.1")] | ||
| [DataRow("2.1.3")] |
There was a problem hiding this comment.
Please explain why you did this?
There was a problem hiding this comment.
The test is for ASP.NET MVC Core (the attributes are not present in the desktop version of ASP.NET MVC)
| get { return 0; } | ||
| set { } | ||
| } | ||
|
|
There was a problem hiding this comment.
Please add a test with an event, an operator and a destructor.
| Set(ByVal value As Integer) | ||
| End Set | ||
| End Property | ||
|
|
Evangelink
approved these changes
Nov 19, 2018
Evangelink
pushed a commit
that referenced
this pull request
Nov 19, 2018
…with NonActionAttribute (#2109)
Evangelink
pushed a commit
that referenced
this pull request
Nov 19, 2018
…with NonActionAttribute (#2109)
Evangelink
pushed a commit
that referenced
this pull request
Nov 19, 2018
…with NonActionAttribute (#2109)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1991