Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule S4529: Exposing HTTP endpoints is security-sensitive #2097

Merged
merged 1 commit into from
Nov 12, 2018

Conversation

valhristov
Copy link
Contributor

@valhristov valhristov commented Nov 12, 2018

Fix #1991

@ghost ghost assigned valhristov Nov 12, 2018
@ghost ghost added the Status: Needs Review label Nov 12, 2018

namespace SonarAnalyzer.ControlFlowGraph.CSharp
namespace SonarAnalyzer.Helpers
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to SonarAnalyzer.Common and changed namespace

Copy link
Contributor

@duncanp-lseg duncanp-lseg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duncanp-lseg duncanp-lseg merged commit 0217dcf into feature/hotspots Nov 12, 2018
@ghost ghost removed the Status: Needs Review label Nov 12, 2018
@duncanp-lseg duncanp-lseg deleted the val/endpoints branch November 12, 2018 15:42
@nicolas-harraudeau-sonarsource

@valhristov I just noticed on Peach that the controller constructors are also highlighted. It create some noise as each Controller has a constructor.
https://peach.sonarsource.com/project/issues?id=simplcommerce&issues=AWcYjPcKJe8TA5tRWzBW&types=SECURITY_HOTSPOT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants