Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework loop handling to also work for counter variables that are not part of the loop condition #8474

Closed
Tim-Pohlmann opened this issue Dec 18, 2023 · 2 comments · Fixed by #8656
Closed

Rework loop handling to also work for counter variables that are not part of the loop condition #8474

Tim-Pohlmann opened this issue Dec 18, 2023 · 2 comments · Fixed by #8656
Assignees
@Tim-Pohlmann
Labels
Area: C# C# rules related issues. Area: CFG/SE CFG and SE related issues. Area: VB.NET VB.NET rules related issues. Type: CFG/SE FPs Rule IS triggered when it shouldn't be for CFG and SE rules.

Comments

@Tim-Pohlmann
Copy link
Contributor

Tim-Pohlmann commented Dec 18, 2023 •
edited
Loading

Plan
PoC: #8452
should fix: #8028, #8428, #8449
@Tim-Pohlmann Tim-Pohlmann added Area: CFG/SE CFG and SE related issues. Area: VB.NET VB.NET rules related issues. Area: C# C# rules related issues. Type: CFG/SE FPs Rule IS triggered when it shouldn't be for CFG and SE rules. labels Dec 18, 2023
@Tim-Pohlmann Tim-Pohlmann mentioned this issue Jan 4, 2024
Closed
Closed
@Tim-Pohlmann Tim-Pohlmann self-assigned this Jan 30, 2024
@Tim-Pohlmann Tim-Pohlmann modified the milestone: 9.20 Jan 31, 2024
This was referenced Jan 31, 2024
Merged
Merged
@Tim-Pohlmann Tim-Pohlmann linked a pull request Feb 5, 2024 that will close this issue
Rework loop fuzzy logic for NumberConstraints #8656
Merged
@Tim-Pohlmann Tim-Pohlmann mentioned this issue Feb 6, 2024
Open
21 tasks
This was referenced Feb 14, 2024
Merged
Closed
Closed
@andrei-epure-sonarsource
Copy link
Contributor

@Tim-Pohlmann is this done?

@Tim-Pohlmann
Copy link
Contributor Author

Yes. For some reason GitHub did not close it with the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tim-Pohlmann Tim-Pohlmann

Labels
Area: C# C# rules related issues. Area: CFG/SE CFG and SE related issues. Area: VB.NET VB.NET rules related issues. Type: CFG/SE FPs Rule IS triggered when it shouldn't be for CFG and SE rules.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rework loop fuzzy logic for NumberConstraints SonarSource/sonar-dotnet
4 participants
@Tim-Pohlmann @andrei-epure-sonarsource @gregory-paidis-sonarsource @zsolt-kolbay-sonarsource