Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve S3900: Support C# 9 and C# 10 syntax #6793

Closed
7 tasks done
pavel-mikula-sonarsource opened this issue Feb 27, 2023 · 0 comments
Closed
7 tasks done

Improve S3900: Support C# 9 and C# 10 syntax #6793

pavel-mikula-sonarsource opened this issue Feb 27, 2023 · 0 comments
Assignees
@zsolt-kolbay-sonarsource
Labels
Area: C# C# rules related issues. Area: CFG/SE CFG and SE related issues.
Milestone
8.56

Comments

@pavel-mikula-sonarsource
Copy link
Contributor

pavel-mikula-sonarsource commented Feb 27, 2023 •
edited by zsolt-kolbay-sonarsource
Loading

Improve precision and detection of S3900 by migrating it to the new SE engine. While keeping the old implementation for Roslyn v1.x and v2.x series.

RSPEC PR: SonarSource/rspec#1620

PRs:

  • Update RSPEC, see Fix the RSPEC Exceptions description for S3900 #2643
  • Clone TestCases from Sonar directory to Roslyn. Mark all Noncompliant as FIXME Non-compliant
  • Create a dummy without implementation, register it in SymbolicExecutionRunner, add test methods
  • Implement ShouldExecute
  • Implement the rule - this depends on the engine capabilities
  • ...investigate and fix whatever is missing
  • Remove remaining FIXME annotations, close FP repro issues as fixed in this sprint
@pavel-mikula-sonarsource pavel-mikula-sonarsource added Type: Improvement Area: CFG/SE CFG and SE related issues. Area: C# C# rules related issues. labels Feb 27, 2023
Closed
@pavel-mikula-sonarsource pavel-mikula-sonarsource added this to the 8.56 milestone Feb 27, 2023
Closed
Merged
Merged
This was referenced Mar 13, 2023
Closed
Merged
Closed
Merged
Merged
This was referenced Mar 29, 2023
Merged
Merged
This was referenced Apr 13, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource

Labels
Area: C# C# rules related issues. Area: CFG/SE CFG and SE related issues.
Projects
None yet
Milestone
8.56
Development

No branches or pull requests
3 participants
@Tim-Pohlmann @pavel-mikula-sonarsource @zsolt-kolbay-sonarsource