Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S1144: Highlight only the identifier name #6321

Closed
costin-zaharia-sonarsource opened this issue Nov 8, 2022 · 0 comments · Fixed by #6679
Closed

S1144: Highlight only the identifier name #6321

costin-zaharia-sonarsource opened this issue Nov 8, 2022 · 0 comments · Fixed by #6679
Assignees
@zsolt-kolbay-sonarsource
Labels
Area: C# C# rules related issues.
Milestone
8.53

Comments

@costin-zaharia-sonarsource
Copy link
Member

costin-zaharia-sonarsource commented Nov 8, 2022 •
edited
Loading

Description

When S1144 is triggered for a method, it will highlight the full method body. This is annoying for the users and can hide other issues as well.

Repro steps

image

Expected behavior

Highlight only the method identifier

Actual behavior

The full method body is highlighted.

Sources:
@andrei-epure-sonarsource andrei-epure-sonarsource added this to the 8.52 milestone Jan 12, 2023
zsolt-kolbay-sonarsource added a commit that referenced this issue Jan 26, 2023
@zsolt-kolbay-sonarsource
Fix for #6321
9373da5
Merged
@pavel-mikula-sonarsource pavel-mikula-sonarsource modified the milestones: 8.52, 8.53 Jan 27, 2023
@antonioaversa antonioaversa mentioned this issue Feb 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource

Labels
Area: C# C# rules related issues.
Projects
None yet
Milestone
8.53
Development

Successfully merging a pull request may close this issue.

Improve S1144: highlight only identifiers SonarSource/sonar-dotnet
5 participants
@andrei-epure-sonarsource @costin-zaharia-sonarsource @pavel-mikula-sonarsource @martin-strecker-sonarsource @zsolt-kolbay-sonarsource