Update S1226: Change contract of the rule to make it become more relevant

[fmallet]

This rule currently triggers an issue as soon as a method parameter is reassigned. With updated RSPEC-1226 this rule is supposed to raise an issue if an only if a method parameter, caught exception or foreach variable is reassigned without having been read before.

To be noted that this rule must be part of Sonar way and becomes a bug detection rule.

Moreover, rule RSPEC-3316 should also be updated to stop spotting such kind of issues.

[rymeskar]

Any news regarding this issue @fmallet and @Evangelink ?

The initial intent of the rule is quite right and preventing one family of bugs.

However, the implementation seems to be triggering even in cases where it should not.

Example is linked list traversal:
while (e != null) { list.Add(FormatMessage(e)); e = e.InnerException; }

[valhristov]

Hi @rymeskar, I created a new ticket from your comment. I am closing this one, as it was implemented but forgotten to be closed.

[andrei-epure-sonarsource]

Hi @rymeskar . I'm trying to reproduce the issue you reported here (for ticket #2249) and, from what I see, this has been fixed in #1712 (so included in 7.4.0.6452).

What version of the SonarAnalyzer are you using?