Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S1226: Variables that are passed as an argument to a method should be considered as read #2249

Closed
valhristov opened this issue Jan 28, 2019 · 1 comment
Closed

Fix S1226: Variables that are passed as an argument to a method should be considered as read #2249

valhristov opened this issue Jan 28, 2019 · 1 comment
Assignees
@andrei-epure-sonarsource
Labels
Area: C# C# rules related issues. Type: False Positive Rule IS triggered when it shouldn't be.
Milestone
7.13

Comments

@valhristov
Copy link
Contributor

valhristov commented Jan 28, 2019 •
edited
Loading

The following code snippet should not raise an issue:

...
catch (Exception e)
{
    while (e != null)
    {
        list.Add(FormatMessage(e));
        e = e.InnerException;
    }
}

Originally posted by @rymeskar in #630 (comment)

Tip: the rule considers a variable read only if it appears on the right hand side of an assignment.
@valhristov valhristov added Area: Rules Type: False Positive Rule IS triggered when it shouldn't be. Area: C# C# rules related issues. labels Jan 28, 2019
@valhristov valhristov mentioned this issue Jan 28, 2019
Closed
@valhristov valhristov added this to the 7.11 milestone Jan 28, 2019
@Evangelink Evangelink modified the milestones: 7.12, 7.13 Mar 25, 2019
Merged
@andrei-epure-sonarsource
Copy link
Contributor

Could not reproduce, I added reproducing tests in #2372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrei-epure-sonarsource andrei-epure-sonarsource

Labels
Area: C# C# rules related issues. Type: False Positive Rule IS triggered when it shouldn't be.
Projects
None yet
Milestone
7.13
Development

No branches or pull requests
3 participants
@Evangelink @valhristov @andrei-epure-sonarsource