Do not stop when MemberAccess or ObjectCreation are nested

SonarSource · May 30, 2024 · ca0b9b4 · ca0b9b4
1 parent 3c6601c
commit ca0b9b4
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/.../SonarAnalyzer.CSharp/SymbolicExecution/Roslyn/SecureRandomSeedsShouldNotBePredictable.cs b/.../SonarAnalyzer.CSharp/SymbolicExecution/Roslyn/SecureRandomSeedsShouldNotBePredictable.cs
@@ -177,10 +177,18 @@ public override void Visit(SyntaxNode node)
             }
         }
 
-        public override void VisitMemberAccessExpression(MemberAccessExpressionSyntax node) =>
+        public override void VisitMemberAccessExpression(MemberAccessExpressionSyntax node)
+        {
             Result |= node.Expression.NameIs("SecureRandom") && node.Name.NameIs("GetInstance");
 
-        public override void VisitObjectCreationExpression(ObjectCreationExpressionSyntax node) =>
+            base.VisitMemberAccessExpression(node);
+        }
+
+        public override void VisitObjectCreationExpression(ObjectCreationExpressionSyntax node)
+        {
             Result |= node.Type.GetName() is "DigestRandomGenerator" or "VmpcRandomGenerator";
+
+            base.VisitObjectCreationExpression(node);
+        }
     }
 }