S6964: Issue is reported on the attribute instead of the property (#9332

)
SonarSource · May 27, 2024 · b76ac90 · b76ac90
1 parent 5fb5a91
commit b76ac90
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/...ers/its/expected/ManuallyAddedNoncompliantIssues.CS/S6964-IntentionalFindings-net8.0.json b/...ers/its/expected/ManuallyAddedNoncompliantIssues.CS/S6964-IntentionalFindings-net8.0.json
@@ -4,7 +4,7 @@
       "Id": "S6964",
       "Message": "Property used as input in a controller action should be nullable or annotated with the Required attribute to avoid under-posting.",
       "Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/ManuallyAddedNoncompliantIssues.CS/IntentionalFindings/S6964.cs#L9",
-      "Location": "Line 9 Position 13-51"
+      "Location": "Line 9 Position 24-37"
     }
   ]
 }
diff --git a/analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/AvoidUnderPosting.cs b/analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/AvoidUnderPosting.cs
@@ -82,7 +82,7 @@ private static void CheckInvalidProperties(INamedTypeSymbol parameterType, Sonar
             .Where(x => !CanBeNull(x.Type) && !x.HasAnyAttribute(ValidationAttributes) && !x.IsRequired());
         foreach (var property in invalidProperties)
         {
-            context.ReportIssue(Rule, property.GetFirstSyntaxRef().GetLocation());
+            context.ReportIssue(Rule, property.GetFirstSyntaxRef().GetIdentifier()?.GetLocation());
         }
     }
 

diff --git a/analyzers/tests/SonarAnalyzer.Test/TestCases/AspNet/AvoidUnderPosting.CSharp12.cs b/analyzers/tests/SonarAnalyzer.Test/TestCases/AspNet/AvoidUnderPosting.CSharp12.cs
@@ -30,8 +30,8 @@ public class Model
     {
         public int ValueProperty { get; set; }              // Noncompliant
 
-        [Custom]                                            // Noncompliant repro for https://github.com/SonarSource/sonar-dotnet/issues/9282
-        public int ValuePropertyAnnotatedWithCustomAttribute { get; set; }
+        [Custom]
+        public int ValuePropertyAnnotatedWithCustomAttribute { get; set; } // Noncompliant
 
         [JsonRequired]                                      // Compliant - the property is annotated with JsonRequiredAttribute
         public int AnotherValueProperty { get; set; }

diff --git a/analyzers/tests/SonarAnalyzer.Test/TestCases/AspNet/AvoidUnderPosting.cs b/analyzers/tests/SonarAnalyzer.Test/TestCases/AspNet/AvoidUnderPosting.cs
@@ -14,7 +14,7 @@ public class ClassNotUsedInRequests
     public class ModelUsedInController
     {
         public int ValueProperty { get; set; }                                      // Noncompliant {{Property used as input in a controller action should be nullable or annotated with the Required attribute to avoid under-posting.}}
-//      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+//                 ^^^^^^^^^^^^^
         public int? NullableValueProperty { get; set; }
         [Required] public int RequiredValueProperty { get; set; }
         [Range(0, 10)] public int ValuePropertyWithRangeValidation { get; set; }    // Noncompliant