Fix S3900 FN: Conversion operations (#7002)

SonarSource · Mar 31, 2023 · 9be9ba3 · 9be9ba3
1 parent 35a86f0
commit 9be9ba3
Show file tree

Hide file tree

Showing 23 changed files with 1,666 additions and 10 deletions.
diff --git a/analyzers/its/expected/Automapper/AutoMapper--net461-S3900.json b/analyzers/its/expected/Automapper/AutoMapper--net461-S3900.json
@@ -392,6 +392,32 @@
 },
 {
 "id":  "S3900",
+"message":  "Refactor this method to add validation of parameter 'enumerableOfProfiles' before using it.",
+"location":  {
+"uri":  "sources\Automapper\src\AutoMapper\Configuration\MapperConfigurationExpression.cs",
+"region":  {
+"startLine":  161,
+"startColumn":  37,
+"endLine":  161,
+"endColumn":  57
+}
+}
+},
+{
+"id":  "S3900",
+"message":  "Refactor this method to add validation of parameter 'memberNames' before using it.",
+"location":  {
+"uri":  "sources\Automapper\src\AutoMapper\Configuration\MappingExpression.cs",
+"region":  {
+"startLine":  37,
+"startColumn":  39,
+"endLine":  37,
+"endColumn":  50
+}
+}
+},
+{
+"id":  "S3900",
 "message":  "Refactor this method to add validation of parameter 'memberOptions' before using it.",
 "location":  {
 "uri":  "sources\Automapper\src\AutoMapper\Configuration\MappingExpression.cs",
@@ -613,6 +639,19 @@
 },
 {
 "id":  "S3900",
+"message":  "Refactor this method to add validation of parameter 'members' before using it.",
+"location":  {
+"uri":  "sources\Automapper\src\AutoMapper\Execution\ExpressionBuilder.cs",
+"region":  {
+"startLine":  170,
+"startColumn":  36,
+"endLine":  170,
+"endColumn":  43
+}
+}
+},
+{
+"id":  "S3900",
 "message":  "Refactor this method to add validation of parameter 'lambda' before using it.",
 "location":  {
 "uri":  "sources\Automapper\src\AutoMapper\Execution\ExpressionBuilder.cs",
@@ -652,6 +691,19 @@
 },
 {
 "id":  "S3900",
+"message":  "Refactor this method to add validation of parameter 'members' before using it.",
+"location":  {
+"uri":  "sources\Automapper\src\AutoMapper\Execution\ExpressionBuilder.cs",
+"region":  {
+"startLine":  232,
+"startColumn":  36,
+"endLine":  232,
+"endColumn":  43
+}
+}
+},
+{
+"id":  "S3900",
 "message":  "Refactor this method to add validation of parameter 'collection' before using it.",
 "location":  {
 "uri":  "sources\Automapper\src\AutoMapper\Execution\ExpressionBuilder.cs",
@@ -964,6 +1016,19 @@
 },
 {
 "id":  "S3900",
+"message":  "Refactor this method to add validation of parameter 'member' before using it.",
+"location":  {
+"uri":  "sources\Automapper\src\AutoMapper\Internal\ReflectionHelper.cs",
+"region":  {
+"startLine":  17,
+"startColumn":  131,
+"endLine":  17,
+"endColumn":  137
+}
+}
+},
+{
+"id":  "S3900",
 "message":  "Refactor this method to add validation of parameter 'parameter' before using it.",
 "location":  {
 "uri":  "sources\Automapper\src\AutoMapper\Internal\ReflectionHelper.cs",
@@ -1029,6 +1094,19 @@
 },
 {
 "id":  "S3900",
+"message":  "Refactor this method to add validation of parameter 'prefixes' before using it.",
+"location":  {
+"uri":  "sources\Automapper\src\AutoMapper\Internal\TypeDetails.cs",
+"region":  {
+"startLine":  75,
+"startColumn":  36,
+"endLine":  75,
+"endColumn":  44
+}
+}
+},
+{
+"id":  "S3900",
 "message":  "Refactor this method to add validation of parameter 'memberName' before using it.",
 "location":  {
 "uri":  "sources\Automapper\src\AutoMapper\Internal\TypeDetails.cs",

diff --git a/analyzers/its/expected/Automapper/AutoMapper--netstandard2.0-S3900.json b/analyzers/its/expected/Automapper/AutoMapper--netstandard2.0-S3900.json
@@ -392,6 +392,32 @@
 },
 {
 "id":  "S3900",
+"message":  "Refactor this method to add validation of parameter 'enumerableOfProfiles' before using it.",
+"location":  {
+"uri":  "sources\Automapper\src\AutoMapper\Configuration\MapperConfigurationExpression.cs",
+"region":  {
+"startLine":  161,
+"startColumn":  37,
+"endLine":  161,
+"endColumn":  57
+}
+}
+},
+{
+"id":  "S3900",
+"message":  "Refactor this method to add validation of parameter 'memberNames' before using it.",
+"location":  {
+"uri":  "sources\Automapper\src\AutoMapper\Configuration\MappingExpression.cs",
+"region":  {
+"startLine":  37,
+"startColumn":  39,
+"endLine":  37,
+"endColumn":  50
+}
+}
+},
+{
+"id":  "S3900",
 "message":  "Refactor this method to add validation of parameter 'memberOptions' before using it.",
 "location":  {
 "uri":  "sources\Automapper\src\AutoMapper\Configuration\MappingExpression.cs",
@@ -613,6 +639,19 @@
 },
 {
 "id":  "S3900",
+"message":  "Refactor this method to add validation of parameter 'members' before using it.",
+"location":  {
+"uri":  "sources\Automapper\src\AutoMapper\Execution\ExpressionBuilder.cs",
+"region":  {
+"startLine":  170,
+"startColumn":  36,
+"endLine":  170,
+"endColumn":  43
+}
+}
+},
+{
+"id":  "S3900",
 "message":  "Refactor this method to add validation of parameter 'lambda' before using it.",
 "location":  {
 "uri":  "sources\Automapper\src\AutoMapper\Execution\ExpressionBuilder.cs",
@@ -652,6 +691,19 @@
 },
 {
 "id":  "S3900",
+"message":  "Refactor this method to add validation of parameter 'members' before using it.",
+"location":  {
+"uri":  "sources\Automapper\src\AutoMapper\Execution\ExpressionBuilder.cs",
+"region":  {
+"startLine":  232,
+"startColumn":  36,
+"endLine":  232,
+"endColumn":  43
+}
+}
+},
+{
+"id":  "S3900",
 "message":  "Refactor this method to add validation of parameter 'collection' before using it.",
 "location":  {
 "uri":  "sources\Automapper\src\AutoMapper\Execution\ExpressionBuilder.cs",
@@ -964,6 +1016,19 @@
 },
 {
 "id":  "S3900",
+"message":  "Refactor this method to add validation of parameter 'member' before using it.",
+"location":  {
+"uri":  "sources\Automapper\src\AutoMapper\Internal\ReflectionHelper.cs",
+"region":  {
+"startLine":  17,
+"startColumn":  131,
+"endLine":  17,
+"endColumn":  137
+}
+}
+},
+{
+"id":  "S3900",
 "message":  "Refactor this method to add validation of parameter 'parameter' before using it.",
 "location":  {
 "uri":  "sources\Automapper\src\AutoMapper\Internal\ReflectionHelper.cs",
@@ -1029,6 +1094,19 @@
 },
 {
 "id":  "S3900",
+"message":  "Refactor this method to add validation of parameter 'prefixes' before using it.",
+"location":  {
+"uri":  "sources\Automapper\src\AutoMapper\Internal\TypeDetails.cs",
+"region":  {
+"startLine":  75,
+"startColumn":  36,
+"endLine":  75,
+"endColumn":  44
+}
+}
+},
+{
+"id":  "S3900",
 "message":  "Refactor this method to add validation of parameter 'memberName' before using it.",
 "location":  {
 "uri":  "sources\Automapper\src\AutoMapper\Internal\TypeDetails.cs",