address comments

SonarSource · Oct 18, 2023 · 8618a9b · 8618a9b
1 parent edf475a
commit 8618a9b
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/analyzers/src/SonarAnalyzer.CSharp/Rules/DoNotMarkEnumsWithFlags.cs b/analyzers/src/SonarAnalyzer.CSharp/Rules/DoNotMarkEnumsWithFlags.cs
@@ -80,20 +80,18 @@ protected override void Initialize(SonarAnalysisContext context) =>
                       uint x => (BigInteger)x,
                       long x => (BigInteger)x,
                       ulong x => (BigInteger)x,
-                      // this is a safeguard for the case when the enum is defined with a base type that is not currently supported by the compiler
-                      var x when BigInteger.TryParse(x.ToString(), out var value) => value,
                       _ => null
                   }
                 : null;
 
         private static bool IsValidFlagValue(BigInteger? enumValue, IEnumerable<BigInteger> allValues) =>
-            enumValue.HasValue && (IsZeroOrPowerOfTwo(enumValue.Value) || IsCombinationOfOtherValues(enumValue.Value, allValues));
+            enumValue.HasValue
+            && (IsZeroOrPowerOfTwo(enumValue.Value)
+                || IsCombinationOfOtherValues(enumValue.Value, allValues));
 
         private static bool IsZeroOrPowerOfTwo(BigInteger value) =>
             value.IsZero
-            || (value.Sign == -1
-                    ? BigInteger.Multiply(value, -1).IsPowerOfTwo
-                    : value.IsPowerOfTwo);
+            || BigInteger.Abs(value).IsPowerOfTwo;
 
         private static bool IsCombinationOfOtherValues(BigInteger value, IEnumerable<BigInteger> otherValues)
         {