Code review 1

SonarSource · Sep 29, 2023 · 769ed49 · 769ed49
1 parent 1f2290e
commit 769ed49
Show file tree

Hide file tree

Showing 5 changed files with 134 additions and 2 deletions.
diff --git a/...SonarAnalyzer.UnitTest/TestCases/RedundancyInConstructorDestructorDeclaration.CSharp12.cs b/...SonarAnalyzer.UnitTest/TestCases/RedundancyInConstructorDestructorDeclaration.CSharp12.cs
@@ -11,5 +11,41 @@ record ARecordWithBody() { }              // FN
         record ARecordWithoutBody();              // FN
         record struct ARecordStructWithBody() { } // FN
         record struct ARecordStructWithoutBody(); // FN
+
+        namespace FieldInitializerInStructRequiresConstructor
+        {
+            struct AStructWithFieldInitializer()              // Compliant
+            {
+                public int aField = 42;
+            }
+
+            struct AStructWithPropertyInitializer()           // Compliant
+            {
+                public int AProperty { get; } = 42;
+            }
+
+            record struct ARecordStructWithFieldInitializer() // Compliant
+            {
+                public int aField = 42;
+            }
+        }
+
+        namespace FieldInitializerInClassDontRequireConstructor
+        {
+            class AClassWithFieldInitializer()       // FN
+            {
+                public int aField = 42;
+            }
+
+            class AClassWithPropertyInitializer()    // FN
+            {
+                public int AProperty { get; } = 42;
+            }
+
+            class ARecordWithFieldInitializer()      // FN
+            {
+                public int aField = 42;
+            }
+        }
     }
 }
diff --git a/analyzers/tests/SonarAnalyzer.UnitTest/TestCases/RedundantArgument.CSharp12.cs b/analyzers/tests/SonarAnalyzer.UnitTest/TestCases/RedundantArgument.CSharp12.cs
@@ -48,8 +48,8 @@ void MultipleDefaultArguments()
             _ = new C2(42);     // Compliant
             _ = new C2(42, 42); // FN
             _ = new C2(41, 42); // FN, multiple violations
-                                //         ~~
-                                //             ~~@-1
+            //         ~~
+            //             ~~@-1
         }
 
         void NamedArguments()

diff --git a/...s/tests/SonarAnalyzer.UnitTest/TestCases/RedundantDeclaration.CSharp12.ArraySize.Fixed.cs b/...s/tests/SonarAnalyzer.UnitTest/TestCases/RedundantDeclaration.CSharp12.ArraySize.Fixed.cs
@@ -37,3 +37,35 @@ void AliasWithEmptyParamsList()
         }
     }
 }
+
+class CollectionExpressions
+{
+    void ExplicitTypeDeclaration()
+    {
+        int[] a1 = [1, 2, 3];         // Compliant
+        a1 = [1, 2, 3];               // Compliant, reassignment
+        int[] a2 = new[] { 1, 2, 3 }; // FN, can be written as [1, 2, 3]
+        a2 = new[] { 1, 2, 3 };       // FN, can be written as [1, 2, 3], reassignment
+    }
+
+    void VarDeclarationWithInlineAssignment()
+    {
+        var invalid = [1, 2, 3];            // Error CS9176  There is no target type for the collection expression.
+    }
+
+    void VarDeclarationWithReassignment()
+    {
+        var typeInferredAndReassigned = new[] { 1, 2, 3 }; // Compliant, cannot be written as [1, 2, 3]
+        typeInferredAndReassigned = new[] { 1, 2, 3 };     // FN, can be written as [1, 2, 3], reassignment of a type-inferred variable
+        typeInferredAndReassigned = new int[] { 1, 2, 3 }; // Fixed
+        typeInferredAndReassigned = [];                    // Compliant
+        typeInferredAndReassigned = new int[] { };         // FN, can be written as []
+    }
+
+    void VarDeclarationWithReassignmentToEmptyCollection()
+    {
+        var typeInferredAndReassigned = new[] { 1, 2, 3 };
+        typeInferredAndReassigned = new[] { };             // Error CS0826 No best type found for implicitly-typed array
+                                                           // Error@-1 CS0029 Cannot implicitly convert type '?[]' to 'int[]'
+    }
+}
diff --git a/...narAnalyzer.UnitTest/TestCases/RedundantDeclaration.CSharp12.LambdaParameterType.Fixed.cs b/...narAnalyzer.UnitTest/TestCases/RedundantDeclaration.CSharp12.LambdaParameterType.Fixed.cs
@@ -37,3 +37,35 @@ void AliasWithEmptyParamsList()
         }
     }
 }
+
+class CollectionExpressions
+{
+    void ExplicitTypeDeclaration()
+    {
+        int[] a1 = [1, 2, 3];         // Compliant
+        a1 = [1, 2, 3];               // Compliant, reassignment
+        int[] a2 = new[] { 1, 2, 3 }; // FN, can be written as [1, 2, 3]
+        a2 = new[] { 1, 2, 3 };       // FN, can be written as [1, 2, 3], reassignment
+    }
+
+    void VarDeclarationWithInlineAssignment()
+    {
+        var invalid = [1, 2, 3];            // Error CS9176  There is no target type for the collection expression.
+    }
+
+    void VarDeclarationWithReassignment()
+    {
+        var typeInferredAndReassigned = new[] { 1, 2, 3 }; // Compliant, cannot be written as [1, 2, 3]
+        typeInferredAndReassigned = new[] { 1, 2, 3 };     // FN, can be written as [1, 2, 3], reassignment of a type-inferred variable
+        typeInferredAndReassigned = new int[] { 1, 2, 3 }; // Fixed
+        typeInferredAndReassigned = [];                    // Compliant
+        typeInferredAndReassigned = new int[] { };         // FN, can be written as []
+    }
+
+    void VarDeclarationWithReassignmentToEmptyCollection()
+    {
+        var typeInferredAndReassigned = new[] { 1, 2, 3 };
+        typeInferredAndReassigned = new[] { };             // Error CS0826 No best type found for implicitly-typed array
+                                                           // Error@-1 CS0029 Cannot implicitly convert type '?[]' to 'int[]'
+    }
+}
diff --git a/analyzers/tests/SonarAnalyzer.UnitTest/TestCases/RedundantDeclaration.CSharp12.cs b/analyzers/tests/SonarAnalyzer.UnitTest/TestCases/RedundantDeclaration.CSharp12.cs
@@ -37,3 +37,35 @@ void AliasWithEmptyParamsList()
         }
     }
 }
+
+class CollectionExpressions
+{
+    void ExplicitTypeDeclaration()
+    {
+        int[] a1 = [1, 2, 3];         // Compliant
+        a1 = [1, 2, 3];               // Compliant, reassignment
+        int[] a2 = new[] { 1, 2, 3 }; // FN, can be written as [1, 2, 3]
+        a2 = new[] { 1, 2, 3 };       // FN, can be written as [1, 2, 3], reassignment
+    }
+
+    void VarDeclarationWithInlineAssignment()
+    {
+        var invalid = [1, 2, 3];            // Error CS9176  There is no target type for the collection expression.
+    }
+
+    void VarDeclarationWithReassignment()
+    {
+        var typeInferredAndReassigned = new[] { 1, 2, 3 }; // Compliant, cannot be written as [1, 2, 3]
+        typeInferredAndReassigned = new[] { 1, 2, 3 };     // FN, can be written as [1, 2, 3], reassignment of a type-inferred variable
+        typeInferredAndReassigned = new int[] { 1, 2, 3 }; // Noncompliant, can be written as [1, 2, 3]
+        typeInferredAndReassigned = [];                    // Compliant
+        typeInferredAndReassigned = new int[] { };         // FN, can be written as []
+    }
+
+    void VarDeclarationWithReassignmentToEmptyCollection()
+    {
+        var typeInferredAndReassigned = new[] { 1, 2, 3 };
+        typeInferredAndReassigned = new[] { };             // Error CS0826 No best type found for implicitly-typed array
+                                                           // Error@-1 CS0029 Cannot implicitly convert type '?[]' to 'int[]'
+    }
+}