Improve S1144: highlight only identifiers (#6679)

SonarSource · Feb 6, 2023 · 6d979a0 · 6d979a0
1 parent 76b08ab
commit 6d979a0
Show file tree

Hide file tree

Showing 34 changed files with 443 additions and 255 deletions.
diff --git a/...AnalyzeGenerated.CS/AnalyzeGeneratedFiles-6389f4a4-59fd-497b-bb52-4414b1320d29-S1144.json b/...AnalyzeGenerated.CS/AnalyzeGeneratedFiles-6389f4a4-59fd-497b-bb52-4414b1320d29-S1144.json
@@ -7,9 +7,9 @@
 "uri":  "sources\GeneratedCode.CS\generated_region.cs",
 "region":  {
 "startLine":  7,
-"startColumn":  9,
-"endLine":  13,
-"endColumn":  10
+"startColumn":  21,
+"endLine":  7,
+"endColumn":  27
 }
 }
 },
@@ -20,9 +20,9 @@
 "uri":  "sources\GeneratedCode.CS\generated_region_2.cs",
 "region":  {
 "startLine":  7,
-"startColumn":  9,
-"endLine":  13,
-"endColumn":  10
+"startColumn":  21,
+"endLine":  7,
+"endColumn":  27
 }
 }
 },
@@ -33,9 +33,9 @@
 "uri":  "sources\GeneratedCode.CS\handwritten.cs",
 "region":  {
 "startLine":  8,
-"startColumn":  9,
-"endLine":  12,
-"endColumn":  10
+"startColumn":  21,
+"endLine":  8,
+"endColumn":  27
 }
 }
 },
@@ -46,9 +46,9 @@
 "uri":  "sources\GeneratedCode.CS\handwritten.cs",
 "region":  {
 "startLine":  14,
-"startColumn":  9,
-"endLine":  16,
-"endColumn":  10
+"startColumn":  22,
+"endLine":  14,
+"endColumn":  25
 }
 }
 }

diff --git a/analyzers/its/expected/Nancy/Nancy--net452-S1144.json b/analyzers/its/expected/Nancy/Nancy--net452-S1144.json
@@ -7,9 +7,9 @@
 "uri":  "sources\Nancy\src\Nancy\Bootstrapper\NancyBootstrapperLocator.cs",
 "region":  {
 "startLine":  66,
-"startColumn":  9,
-"endLine":  82,
-"endColumn":  10
+"startColumn":  29,
+"endLine":  66,
+"endColumn":  47
 }
 }
 },
@@ -20,9 +20,9 @@
 "uri":  "sources\Nancy\src\Nancy\Conventions\StaticContentConventionBuilder.cs",
 "region":  {
 "startLine":  277,
-"startColumn":  13,
-"endLine":  280,
-"endColumn":  14
+"startColumn":  27,
+"endLine":  277,
+"endColumn":  35
 }
 }
 },
@@ -33,9 +33,9 @@
 "uri":  "sources\Nancy\src\Nancy\Routing\DefaultRouteCacheProvider.cs",
 "region":  {
 "startLine":  76,
-"startColumn":  13,
-"endLine":  93,
-"endColumn":  14
+"startColumn":  55,
+"endLine":  76,
+"endColumn":  67
 }
 }
 },
@@ -46,9 +46,9 @@
 "uri":  "sources\Nancy\src\Nancy\TinyIoc\TinyIoC.cs",
 "region":  {
 "startLine":  3843,
-"startColumn":  9,
-"endLine":  3846,
-"endColumn":  10
+"startColumn":  24,
+"endLine":  3843,
+"endColumn":  37
 }
 }
 }

diff --git a/analyzers/its/expected/Nancy/Nancy--netstandard2.0-S1144.json b/analyzers/its/expected/Nancy/Nancy--netstandard2.0-S1144.json
@@ -20,9 +20,9 @@
 "uri":  "sources\Nancy\src\Nancy\Conventions\StaticContentConventionBuilder.cs",
 "region":  {
 "startLine":  277,
-"startColumn":  13,
-"endLine":  280,
-"endColumn":  14
+"startColumn":  27,
+"endLine":  277,
+"endColumn":  35
 }
 }
 },
@@ -33,9 +33,9 @@
 "uri":  "sources\Nancy\src\Nancy\Routing\DefaultRouteCacheProvider.cs",
 "region":  {
 "startLine":  76,
-"startColumn":  13,
-"endLine":  93,
-"endColumn":  14
+"startColumn":  55,
+"endLine":  76,
+"endColumn":  67
 }
 }
 },
@@ -46,9 +46,9 @@
 "uri":  "sources\Nancy\src\Nancy\TinyIoc\TinyIoC.cs",
 "region":  {
 "startLine":  3350,
-"startColumn":  9,
-"endLine":  3372,
-"endColumn":  10
+"startColumn":  22,
+"endLine":  3350,
+"endColumn":  39
 }
 }
 },
@@ -59,9 +59,9 @@
 "uri":  "sources\Nancy\src\Nancy\TinyIoc\TinyIoC.cs",
 "region":  {
 "startLine":  3843,
-"startColumn":  9,
-"endLine":  3846,
-"endColumn":  10
+"startColumn":  24,
+"endLine":  3843,
+"endColumn":  37
 }
 }
 }

diff --git a/analyzers/its/expected/Nancy/Nancy.Testing--net452-S1144.json b/analyzers/its/expected/Nancy/Nancy.Testing--net452-S1144.json
@@ -7,9 +7,9 @@
 "uri":  "sources\Nancy\src\Nancy.Testing\ConfigurableBootstrapper.cs",
 "region":  {
 "startLine":  189,
-"startColumn":  9,
-"endLine":  192,
-"endColumn":  10
+"startColumn":  31,
+"endLine":  189,
+"endColumn":  51
 }
 }
 }

diff --git a/analyzers/its/expected/Nancy/Nancy.Testing--netstandard2.0-S1144.json b/analyzers/its/expected/Nancy/Nancy.Testing--netstandard2.0-S1144.json
@@ -7,9 +7,9 @@
 "uri":  "sources\Nancy\src\Nancy.Testing\ConfigurableBootstrapper.cs",
 "region":  {
 "startLine":  189,
-"startColumn":  9,
-"endLine":  192,
-"endColumn":  10
+"startColumn":  31,
+"endLine":  189,
+"endColumn":  51
 }
 }
 }