Add S4143 FP repro for #2674

SonarSource · Nov 7, 2019 · 28a3602 · 28a3602
1 parent 5a212e4
commit 28a3602
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/...nalyzer-dotnet/tests/SonarAnalyzer.UnitTest/TestCases/DoNotOverwriteCollectionElements.cs b/...nalyzer-dotnet/tests/SonarAnalyzer.UnitTest/TestCases/DoNotOverwriteCollectionElements.cs
@@ -39,6 +39,13 @@ void SameIndexOnList(List<int> list)
             list[0] = 42; // Noncompliant
         }
 
+        void ListAddFP(List<int> list)
+        {
+            // FP - List.Add method should not raise any issue when used with same elements
+            list.Add(42); // Secondary
+            list.Add(42); // Noncompliant
+        }
+
         void SameIndexOnArray(CustomIndexerOneArg obj)
         {
             obj["foo"] = 42; // Compliant, not a collection or dictionary

diff --git a/...nalyzer-dotnet/tests/SonarAnalyzer.UnitTest/TestCases/DoNotOverwriteCollectionElements.vb b/...nalyzer-dotnet/tests/SonarAnalyzer.UnitTest/TestCases/DoNotOverwriteCollectionElements.vb
@@ -62,6 +62,11 @@ Namespace Tests.TestCases
       list(0) = 1 ' Noncompliant
     End Sub
 
+	Private Sub ListAddFP(ByVal list As List(Of String))
+      list.Add("MyText") ' Secondary
+      list.Add("MyText") ' Noncompliant
+    End Sub
+
     Private Sub SameIndexSpacedOut(ByVal names() As String)
       names("a") = "a" ' Secondary
       names("b") = "b"