Skip to content

Commit

Permalink
Rule S1066: Collapsible 'if' statements should be merged (#2263)
Browse files Browse the repository at this point in the history 
Fix #2054
  • Loading branch information
@andrei-epure-sonarsource
Amaury Levé authored and andrei-epure-sonarsource committed Feb 6, 2019
1 parent ec9ebe3 commit 19c2b3c
Show file tree
Hide file tree
Showing 22 changed files with 3,403 additions and 14 deletions.
580 changes: 580 additions & 0 deletions ...s/expected/Ember-MM/Ember Media Manager-{9B57D3AB-AF12-4012-B945-284C2448DC81}-S1066.json
View file

Large diffs are not rendered by default.

484 changes: 484 additions & 0 deletions ...r-dotnet/its/expected/Ember-MM/EmberAPI-{208AA35E-C6AE-4D2D-A9DD-B6EFD19A4279}-S1066.json
View file

Large diffs are not rendered by default.

52 changes: 52 additions & 0 deletions ...d/Ember-MM/generic.EmberCore.BulkRename-{EAAB0601-6478-44D2-A39C-89B0850D7833}-S1066.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
{
"issues": [
{
"id": "S1066",
"message": "Merge this if statement with the enclosing one.",
"location": [
{
"uri": "sources\Ember-MM\Addons\generic.EmberCore.BulkRename\clsAPIRenamer.vb",
"region": {
"startLine": 457,
"startColumn": 29,
"endLine": 457,
"endColumn": 31
}
},
{
"uri": "sources\Ember-MM\Addons\generic.EmberCore.BulkRename\clsAPIRenamer.vb",
"region": {
"startLine": 456,
"startColumn": 25,
"endLine": 456,
"endColumn": 27
}
}
]
},
{
"id": "S1066",
"message": "Merge this if statement with the enclosing one.",
"location": [
{
"uri": "sources\Ember-MM\Addons\generic.EmberCore.BulkRename\clsAPIRenamer.vb",
"region": {
"startLine": 703,
"startColumn": 21,
"endLine": 703,
"endColumn": 23
}
},
{
"uri": "sources\Ember-MM\Addons\generic.EmberCore.BulkRename\clsAPIRenamer.vb",
"region": {
"startLine": 702,
"startColumn": 17,
"endLine": 702,
"endColumn": 19
}
}
]
}
]
}
52 changes: 52 additions & 0 deletions ...expected/Ember-MM/generic.EmberCore.NMT-{84B2143A-D04F-4262-923D-21AEDF86E2B7}-S1066.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
{
"issues": [
{
"id": "S1066",
"message": "Merge this if statement with the enclosing one.",
"location": [
{
"uri": "sources\Ember-MM\Addons\generic.EmberCore.NMT\dlgNMTMovies.vb",
"region": {
"startLine": 1732,
"startColumn": 21,
"endLine": 1732,
"endColumn": 23
}
},
{
"uri": "sources\Ember-MM\Addons\generic.EmberCore.NMT\dlgNMTMovies.vb",
"region": {
"startLine": 1731,
"startColumn": 17,
"endLine": 1731,
"endColumn": 19
}
}
]
},
{
"id": "S1066",
"message": "Merge this if statement with the enclosing one.",
"location": [
{
"uri": "sources\Ember-MM\Addons\generic.EmberCore.NMT\dlgNMTMovies.vb",
"region": {
"startLine": 608,
"startColumn": 25,
"endLine": 608,
"endColumn": 27
}
},
{
"uri": "sources\Ember-MM\Addons\generic.EmberCore.NMT\dlgNMTMovies.vb",
"region": {
"startLine": 607,
"startColumn": 21,
"endLine": 607,
"endColumn": 23
}
}
]
}
]
}
76 changes: 76 additions & 0 deletions ...mber-MM/generic.EmberCore.OfflineHolder-{E7FDD1C9-BCF7-4624-B033-D3888E422A8B}-S1066.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
{
"issues": [
{
"id": "S1066",
"message": "Merge this if statement with the enclosing one.",
"location": [
{
"uri": "sources\Ember-MM\Addons\generic.EmberCore.OfflineHolder\dlgOfflineHolder.vb",
"region": {
"startLine": 70,
"startColumn": 17,
"endLine": 70,
"endColumn": 19
}
},
{
"uri": "sources\Ember-MM\Addons\generic.EmberCore.OfflineHolder\dlgOfflineHolder.vb",
"region": {
"startLine": 69,
"startColumn": 13,
"endLine": 69,
"endColumn": 15
}
}
]
},
{
"id": "S1066",
"message": "Merge this if statement with the enclosing one.",
"location": [
{
"uri": "sources\Ember-MM\Addons\generic.EmberCore.OfflineHolder\dlgOfflineHolder.vb",
"region": {
"startLine": 81,
"startColumn": 17,
"endLine": 81,
"endColumn": 19
}
},
{
"uri": "sources\Ember-MM\Addons\generic.EmberCore.OfflineHolder\dlgOfflineHolder.vb",
"region": {
"startLine": 80,
"startColumn": 13,
"endLine": 80,
"endColumn": 15
}
}
]
},
{
"id": "S1066",
"message": "Merge this if statement with the enclosing one.",
"location": [
{
"uri": "sources\Ember-MM\Addons\generic.EmberCore.OfflineHolder\dlgOfflineHolder.vb",
"region": {
"startLine": 92,
"startColumn": 17,
"endLine": 92,
"endColumn": 19
}
},
{
"uri": "sources\Ember-MM\Addons\generic.EmberCore.OfflineHolder\dlgOfflineHolder.vb",
"region": {
"startLine": 91,
"startColumn": 13,
"endLine": 91,
"endColumn": 15
}
}
]
}
]
}
28 changes: 28 additions & 0 deletions ...ed/Ember-MM/generic.EmberCore.WebServer-{64D6F035-F186-4193-AF35-D20126B8DA64}-S1066.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
{
"issues": [
{
"id": "S1066",
"message": "Merge this if statement with the enclosing one.",
"location": [
{
"uri": "sources\Ember-MM\Addons\generic.EmberCore.WebServer\Server\clsWebContent.vb",
"region": {
"startLine": 205,
"startColumn": 45,
"endLine": 205,
"endColumn": 47
}
},
{
"uri": "sources\Ember-MM\Addons\generic.EmberCore.WebServer\Server\clsWebContent.vb",
"region": {
"startLine": 204,
"startColumn": 41,
"endLine": 204,
"endColumn": 43
}
}
]
}
]
}
28 changes: 28 additions & 0 deletions ...s/expected/Ember-MM/multi.Compatibility-{859C1085-518B-49D2-9C84-D91C4094097F}-S1066.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
{
"issues": [
{
"id": "S1066",
"message": "Merge this if statement with the enclosing one.",
"location": [
{
"uri": "sources\Ember-MM\Addons\multi.Compatibility\genericBoxee.vb",
"region": {
"startLine": 119,
"startColumn": 8,
"endLine": 119,
"endColumn": 10
}
},
{
"uri": "sources\Ember-MM\Addons\multi.Compatibility\genericBoxee.vb",
"region": {
"startLine": 118,
"startColumn": 7,
"endLine": 118,
"endColumn": 9
}
}
]
}
]
}
28 changes: 28 additions & 0 deletions ...its/expected/Ember-MM/multi.EmberExtras-{62356BCF-D15A-4BF1-B980-395CEC0004A9}-S1066.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
{
"issues": [
{
"id": "S1066",
"message": "Merge this if statement with the enclosing one.",
"location": [
{
"uri": "sources\Ember-MM\Addons\multi.EmberExtras\frmGenresEditor.vb",
"region": {
"startLine": 187,
"startColumn": 13,
"endLine": 187,
"endColumn": 15
}
},
{
"uri": "sources\Ember-MM\Addons\multi.EmberExtras\frmGenresEditor.vb",
"region": {
"startLine": 186,
"startColumn": 9,
"endLine": 186,
"endColumn": 11
}
}
]
}
]
}
Loading

0 comments on commit 19c2b3c

Please sign in to comment.