Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify S4050: Promote C# rule to SonarWay #4135

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Modify S4050: Promote C# rule to SonarWay #4135

merged 1 commit into from
Aug 9, 2024

Conversation

sebastien-marichal
Copy link
Contributor

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Aug 9, 2024

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Aug 9, 2024

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sebastien-marichal sebastien-marichal mentioned this pull request Aug 9, 2024
Merged
zsolt-kolbay-sonarsource
zsolt-kolbay-sonarsource approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rules/S4050/csharp/rule.adoc Show resolved Hide resolved
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource merged commit dce07c6 into master Aug 9, 2024
11 of 12 checks passed
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource deleted the sma/modify-s4050 branch August 9, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource approved these changes

Assignees
No one assigned
Labels
dotnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastien-marichal @zsolt-kolbay-sonarsource