Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify rules: Rename STIG version in metadata #4098

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

jamie-anderson-sonarsource
Copy link
Contributor

The Security Technical Implementation Guide security standard is being renamed from its release date (2023-06-08) to its official version and revision number (V5R3). This helps to align with the version number being used internally for reporting purposes.

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

The Security Technical Implementation Guide security standard is being
renamed from its release date (`2023-06-08`) to its official version and
revision number (`V5R3`). This helps to align with the version number
being used internally for reporting purposes.
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@sallaigy sallaigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for taking care of this!

@sallaigy sallaigy merged commit d255072 into master Jul 30, 2024
11 checks passed
@sallaigy sallaigy deleted the rename-stig-version branch July 30, 2024 14:10
jamie-anderson-sonarsource added a commit that referenced this pull request Aug 14, 2024
The STIG metadata section name was changed in PR #4098 but the PR for rule S7001 was not merged until afterwards. This fixes the metadata name.
jamie-anderson-sonarsource added a commit that referenced this pull request Aug 14, 2024
The STIG metadata section name was changed in PR #4098 but the PR for rule S7001 was not merged until afterwards. This fixes the metadata name.
jamie-anderson-sonarsource added a commit that referenced this pull request Aug 14, 2024
The STIG metadata section name was changed in PR #4098 but the PR for rule S7003 was not merged until afterwards. This fixes the metadata name.
jamie-anderson-sonarsource added a commit that referenced this pull request Aug 14, 2024
The STIG metadata section name was changed in PR #4098 but the PR for rule S7003 was not merged until afterwards. This fixes the metadata name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants