-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify rule S2094: Add an exception #3867
Conversation
4789a83
to
1f3da6e
Compare
1f3da6e
to
288928a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left 1 opinionated comment about bulleted list
rules/S2094/exceptions-dotnet.adoc
Outdated
@@ -0,0 +1,13 @@ | |||
Partial classes are ignored entirely, as source generators often use them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opinionated comment: I think this is the perfect place for a bulleted list!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- why all the empty spaces between the sentences?
|
|
Implementation tickets:
Implicit parameterless constructor widens the scope of the base class constructor
Should not raise for messages
Review
A dedicated reviewer checked the rule description successfully for: