Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify rule S2094: Add an exception #3867

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

Tim-Pohlmann
Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann commented Apr 11, 2024

Implementation tickets:
Implicit parameterless constructor widens the scope of the base class constructor
Should not raise for messages

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@Tim-Pohlmann Tim-Pohlmann force-pushed the Tim/S2094_Exceptions branch from 1f3da6e to 288928a Compare April 15, 2024 07:30
Copy link
Contributor

@CristianAmbrosini CristianAmbrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left 1 opinionated comment about bulleted list

@@ -0,0 +1,13 @@
Partial classes are ignored entirely, as source generators often use them.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opinionated comment: I think this is the perfect place for a bulleted list!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • why all the empty spaces between the sentences?

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@Tim-Pohlmann Tim-Pohlmann merged commit 2f851ec into master Apr 15, 2024
10 of 11 checks passed
@Tim-Pohlmann Tim-Pohlmann deleted the Tim/S2094_Exceptions branch April 15, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants