Create rule S1312: Add C# #2488
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
cristian-ambrosini-sonarsource
changed the title
rules/S1312/rule-dotnet.adoc
Outdated
|
|
||
| This rule should be activated when https://en.wikipedia.org/wiki/Service_locator_pattern[Service Locator Design pattern] is followed in place of https://en.wikipedia.org/wiki/Dependency_injection[Dependency Injection] for logging. | ||
|
|
||
| The rule will support the most popular logging frameworks: |
There was a problem hiding this comment.
will support -> supports
rules/S1312/csharp/resources.adoc
Outdated
| @@ -0,0 +1,3 @@ | |||
| * Microsoft Learn - https://learn.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/access-modifiers[Access modifiers] | |||
| * Microsoft Learn - https://learn.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/static-classes-and-static-class-members[Static class members] | |||
There was a problem hiding this comment.
In the VB.NET version of resources Shared is considered a keyword (i.e. it's backticked), but here static it is not (second link).
I would change here, to use backtick as for VB.NET.
There was a problem hiding this comment.
In addition: should/can we use the adoc variables, defined at /rule.adoc level?
There was a problem hiding this comment.
I don't think we should considering that those resources are already language specific, but this is not a strong opinion
|
SonarQube Quality Gate for 'rspec-frontend'
|
|
SonarQube Quality Gate for 'rspec-tools'
|
gregory-paidis-sonarsource
removed the request for review
from csaba-sagi-sonarsource
|
|
gregory-paidis-sonarsource
changed the title
You can preview this rule here (updated a few minutes after each push).
Review
A dedicated reviewer checked the rule description successfully for: