Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only babel-eslint to parse #1143

Closed
wants to merge 1 commit into from

Conversation

simonedavico
Copy link

Update tests to check for babel-eslint error messages. I was forced to comment out the duplicate identifier test, because babel does not throw errors for duplicate identifiers (see this issue).

Fixes #1100 #1141

Would this be a viable approach? I initially wanted to add a config flag to allow switching between espree and babel-eslint, but it would complicate some cases (e.g., Flow files cannot be parsed by espree).

Update tests to check for babel-eslint error messages
@vilchik-elena
Copy link
Contributor

@simonedavico thanks for PR! it's all ok from the implementation point of view, but I'm not yet sure that's the way we want to go for parsing.
We will consider it more carefully next time we will have a sprint for SonarJS (hopefully in Feb).

@simonedavico
Copy link
Author

Sure, I just needed a fix for our internal infrastructure since we are using stage-0 features, and I thought that while I was at it I could contribute back. Hope you will take into consideration my observations on issue #1100 when you decide how much JS ecosystem you want to support :) thanks!

@slikts
Copy link

slikts commented Jan 29, 2019

I'd like to try running this patched version of SonarJS, but not sure how to proceed after building the .jar files; what would be the way to run the patched version with sonar-scanner?

@simonedavico
Copy link
Author

@slikts you can find the docs for manually installing plugins here.

@vilchik-elena
Copy link
Contributor

Fixed in #1183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants