Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HP Moonshot 1500 support #161

Merged
merged 3 commits into from
Aug 20, 2020
Merged

Conversation

cyrinux
Copy link
Collaborator

@cyrinux cyrinux commented Aug 18, 2020

Hi,

I add the support of hp moonshot 1500 with ProLiant m750, m710x and m750 server cartridge.
I take the decison after digging a lot to declare that a moonshot is like a "blade".

(little linting btw)
Hope this help,

Regards,

@cyrinux cyrinux force-pushed the add_moonshot_1500_bis branch from 72190e1 to 08a42aa Compare August 19, 2020 07:54
@Solvik
Copy link
Owner

Solvik commented Aug 20, 2020

thanks for this new hardware support @cyrinux !!
would you be able to commit a dmidecode output and put it in a few tests ?

@cyrinux
Copy link
Collaborator Author

cyrinux commented Aug 20, 2020

thanks for this new hardware support @cyrinux !!
would you be able to commit a dmidecode output and put it in a few tests ?

Sure, i try to do this and ping you if I dont find how to do :D

@cyrinux
Copy link
Collaborator Author

cyrinux commented Aug 20, 2020

I add a test about getting the two serial numbers, it pass in tox pytest. Is it OK for you?

@cyrinux cyrinux force-pushed the add_moonshot_1500_bis branch from 65e162c to f4ffcaa Compare August 20, 2020 13:31
@Solvik
Copy link
Owner

Solvik commented Aug 20, 2020

awesome 👍

@Solvik Solvik merged commit e95a66d into Solvik:master Aug 20, 2020
devopstales pushed a commit to devopstales/netbox-agent2 that referenced this pull request Jun 24, 2022
* Add HP Moonshot 1500 support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants