Add warning if no MAC was found but requested as identifier

Solvik · Jan 21, 2025 · 777100b · 777100b
1 parent d53e650
commit 777100b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/netbox_agent/config.py b/netbox_agent/config.py
@@ -124,7 +124,7 @@ def get_config():
         "--network.nic_id",
         choices=("name", "mac"),
         default="name",
-        help="What property to use as NIC identifier. Always fallback to name if choice is not available",
+        help="What property to use as NIC identifier",
     )
     p.add_argument(
         "--network.primary_mac",

diff --git a/netbox_agent/network.py b/netbox_agent/network.py
@@ -435,10 +435,14 @@ def create_or_update_netbox_ip_on_interface(self, ip, interface):
     def _nic_identifier(self, nic):
         if isinstance(nic, dict):
             if config.network.nic_id == "mac":
+                if not nic["mac"]:
+                    logging.warning("MAC not available while trying to use it as the NIC identifier")
                 return nic["mac"]
             return nic["name"]
         else:
             if config.network.nic_id == "mac":
+                if not nic.mac_address:
+                    logging.warning("MAC not available while trying to use it as the NIC identifier")
                 return nic.mac_address
             return nic.name