-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression in AnkerMake profiles #7641
Conversation
Reverting the changes that got introduced with the merge request SoftFever#7117. This should fix SoftFever#7633
also just an FYI. Instead of making a new commit for a revert, it's proper and much better just to do a git revert instead of changing the values in a new commit. |
How on earth does a 3mm retraction is ever needed for a DDE printer? |
It isn't. Anker's values in their slicer are not a trustworthy source of truth. |
Saw that, it's all good man, that said, there is ALSO a change in this PR that is worthwhile. The Jerk settings in the actual print profile are set higher than what is technically the machine limit, and they SHOULD be swapped. It's an old error I made and haven't had the time/headspace to fix. |
@Xelinor in that case it's better for git purposes to revert the commit first and modify or make a new PR with that change. It's just better for git history and other reasons to do it that way. |
Yep, no, I totally agree with you there, just an fyi |
It's fine, looking at the way @Patnnn submitted it, it's not quite correct either, I'll take some time tonight and get a submission done to finally get this off my to-do list. Jerk can probably be set a bit higher for fast mode then for the non-fast mode profiles, so that needs to be adjusted and validated too, and I have the files already set up to do the test prints so I'll just do that and make the changes. |
Thanks for the info. It was my first GitHub commit ever. So I'm not really have any experience on how to do this correctly. I will close this PR for now |
Reverting the changes that got introduced with the merge request #7117.
This should fix #7633
In addition, this PR swaps the jerk setting from the machine limits tab and the print profile. These were accidentally swapped when @Xelinor initially created these profiles. This should remove the warning that the jerk settings exceed the printer limits.