Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in AnkerMake profiles #7641

Closed
wants to merge 1 commit into from
Closed

Conversation

Patnnn
Copy link

@Patnnn Patnnn commented Dec 2, 2024

Reverting the changes that got introduced with the merge request #7117.

This should fix #7633

In addition, this PR swaps the jerk setting from the machine limits tab and the print profile. These were accidentally swapped when @Xelinor initially created these profiles. This should remove the warning that the jerk settings exceed the printer limits.

Reverting the changes that got introduced with the merge request SoftFever#7117.

This should fix SoftFever#7633
@robertbaker
Copy link
Contributor

robertbaker commented Dec 4, 2024

The M5 doesn't have this problem.
Compare the values yourself in anker's studio by adding a M5 and looking at the values compared to the M5C. I provided screenshots showing the values in Anker's Studio 1.5.24 (latest as of writing)

M5:
m5-general
M5C:
m5c-general

M5:
m5-gcode
M5C:
m5c-gcode

M5:
m5-extruder
M5C:
m5c-extruder

M5:
m5-machine-limits
M5C:
m5c-machine-limits

@robertbaker
Copy link
Contributor

also just an FYI. Instead of making a new commit for a revert, it's proper and much better just to do a git revert instead of changing the values in a new commit.

@robertbaker
Copy link
Contributor

M5C  4 extruder
M5  4 extruder

M5c  2 extruder
m5  2 extruder

M5c  8 extruder
M5  8 extruder

M5c  6 extruder
M5  6 extruder

@Noisyfox
Copy link
Collaborator

Noisyfox commented Dec 4, 2024

How on earth does a 3mm retraction is ever needed for a DDE printer?

@Xelinor
Copy link
Contributor

Xelinor commented Dec 4, 2024

How on earth does a 3mm retraction is ever needed for a DDE printer?

It isn't. Anker's values in their slicer are not a trustworthy source of truth.

@robertbaker
Copy link
Contributor

robertbaker commented Dec 4, 2024

Thank you @Xelinor for the info. I submitted a PR to revert the change. It worked fine for the M5 and since the M5C has identical values, I had no idea it would cause such an issue for the M5C.

#7659 fixes the issue and does a git revert, so this PR can be closed.

@Xelinor
Copy link
Contributor

Xelinor commented Dec 4, 2024

Thank you @Xelinor for the info. I submitted a PR to revert the change. It worked fine for the M5 and since the M5C has identical values, I had no idea it would cause such an issue for the M5C.

Saw that, it's all good man, that said, there is ALSO a change in this PR that is worthwhile. The Jerk settings in the actual print profile are set higher than what is technically the machine limit, and they SHOULD be swapped. It's an old error I made and haven't had the time/headspace to fix.

@robertbaker
Copy link
Contributor

@Xelinor in that case it's better for git purposes to revert the commit first and modify or make a new PR with that change. It's just better for git history and other reasons to do it that way.

@Xelinor
Copy link
Contributor

Xelinor commented Dec 4, 2024

@Xelinor in that case it's better for git purposes to revert the commit first and modify or make a new PR with that change. It's just better for git history and other reasons to do it that way.

Yep, no, I totally agree with you there, just an fyi

@robertbaker
Copy link
Contributor

@Xelinor if you could tell me what to change I can do that PR now unless @Patnnn wants to do it. I don't mind either way.

@Xelinor
Copy link
Contributor

Xelinor commented Dec 4, 2024

@Xelinor if you could tell me what to change I can do that PR now unless @Patnnn wants to do it. I don't mind either way.

It's fine, looking at the way @Patnnn submitted it, it's not quite correct either, I'll take some time tonight and get a submission done to finally get this off my to-do list. Jerk can probably be set a bit higher for fast mode then for the non-fast mode profiles, so that needs to be adjusted and validated too, and I have the files already set up to do the test prints so I'll just do that and make the changes.

@Patnnn
Copy link
Author

Patnnn commented Dec 4, 2024

also just an FYI. Instead of making a new commit for a revert, it's proper and much better just to do a git revert instead of changing the values in a new commit.

Thanks for the info. It was my first GitHub commit ever. So I'm not really have any experience on how to do this correctly. I will close this PR for now

@Patnnn Patnnn closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression on 2.2.0 causing underextrusion
4 participants