Port tests #49
Merged
Port tests #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks this is a big help. No need for the submodules "cell" and "stream" for the tests, all the tests can just sit in the tests module as the tests aren't really tied to a particular type of sodium object, but that's just me being picky. I'll review this later today before I merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translate some of the commented out tests from typescript(?) into Rust. This is maybe partial work on #11?
I also moved all of the Sodium related tests into one tests file as you mentioned in #48. I left the
mem_testandnode_testas separate modules because they don't seem as related to the core of Sodium.