Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for lcobucci/jwt 5.0 #1006

Merged
merged 1 commit into from
Apr 30, 2023
Merged

Add support for lcobucci/jwt 5.0 #1006

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Apple/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@
"ext-json": "*",
"ext-openssl": "*",
"firebase/php-jwt": "^6.2",
"lcobucci/jwt": "^4.1.5",
"lcobucci/clock": "^2.0 || ^3.0",
"lcobucci/jwt": "^4.1.5 || ^5.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any breaking changes here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is list of all official BC-break changes of lcobucci/jwt for upgrate from v.4 to v.5:

Minimum PHP for v.5 is 8.1, that's why I kept using the older version as well "^4.1.5 || ^5.0.0", but functionality in this package is compatible with both versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

"socialiteproviders/manager": "~4.0"
},
"suggest": {
Expand Down