Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build warnings #347

Open
marinier opened this issue Dec 20, 2022 · 3 comments
Open

Fix build warnings #347

marinier opened this issue Dec 20, 2022 · 3 comments
Labels
help-wanted infrastructure build and infrastructure

Comments

@marinier
Copy link
Contributor

There are a lot of warnings during the build. Some of them might even be real problems. I imagine they are different on windows vs. linux vs. OS X, too.

Here are the warnings I get when building from Visual Studio 2019's developer command prompt:

C:\Users\bob.marinier\AppData\Local\Programs\Python\Python39\lib\subprocess.py:937: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used
scons: warning: MSVC version '14.29' was not found.
Core\SVS\viewer\input.c(245): warning C4244: '=': conversion from 'real' to 'int', possible loss of data
Core\SVS\viewer\util.c(224): warning C4113: 'void (__cdecl *)()' differs in parameter lists from 'void (__cdecl *)(void)'
Core\SVS\viewer\viewer.c(30): warning C4305: 'initializing': truncation from 'double' to 'GLfloat'
Core\SVS\viewer\viewer.c(373): warning C4244: 'function': conversion from 'real' to 'int', possible loss of data
C:\Users\bob.marinier\git\Soar\Core\shared\assert.hpp(18): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'SoarAssertionException'
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\decision_process\rete.cpp(2477): warning C4312: 'reinterpret_cast': conversion from 'int' to 'void *' of greater size
Core\SoarKernel\src\decision_process\run_soar.cpp(171): warning C4312: 'reinterpret_cast': conversion from 'int' to 'soar_call_data' of greater size
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
C:\Users\bob.marinier\git\Soar\Core\SoarKernel\src\explanation_memory\instantiation_record.cpp(290) : warning C4700: uninitialized local variable 'rhs' used
C:\Users\bob.marinier\git\Soar\Core\SoarKernel\src\explanation_memory\instantiation_record.cpp(599) : warning C4700: uninitialized local variable 'rhs' used
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
C:\Users\bob.marinier\git\Soar\Core\SoarKernel\src\parsing\parser.cpp(1241) : warning C4700: uninitialized local variable 'c' used
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\semantic_memory\smem_activation.cpp(30): warning C4244: '=': conversion from 'double' to 'uint64_t', possible loss of data
Core\SoarKernel\src\semantic_memory\smem_activation.cpp(262): warning C4244: 'argument': conversion from 'double' to 'uint64_t', possible loss of data
Core\SoarKernel\src\semantic_memory\smem_activation.cpp(274): warning C4244: 'argument': conversion from 'double' to 'uint64_t', possible loss of data
Core\SoarKernel\src\semantic_memory\smem_activation.cpp(353): warning C4305: 'argument': truncation from 'unsigned __int64' to 'double'
Core\SoarKernel\src\semantic_memory\smem_activation.cpp(1155): warning C4805: '==': unsafe mix of type 'T' and type 'bool' in operation
C:\Users\bob.marinier\git\Soar\Core\SoarKernel\src\semantic_memory\smem_activation.cpp(396) : warning C4700: uninitialized local variable 'previous_time' used
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
C:\Users\bob.marinier\git\Soar\Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
C:\Users\bob.marinier\git\Soar\Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
C:\Users\bob.marinier\git\Soar\Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
C:\Users\bob.marinier\git\Soar\Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
C:\Users\bob.marinier\git\Soar\Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
C:\Users\bob.marinier\git\Soar\Core\SoarKernel\src\soar_representation\production_reorder.cpp(337) : warning C4700: uninitialized local variable 'c' used
C:\Users\bob.marinier\git\Soar\Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
C:\Users\bob.marinier\git\Soar\Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\rhs_functions_math.cpp(530): warning C4244: '=': conversion from 'int64_t' to 'double', possible loss of data
Core\SoarKernel\src\soar_representation\rhs_functions_math.cpp(553): warning C4244: '=': conversion from 'int64_t' to 'double', possible loss of data
Core\SoarKernel\src\soar_representation\rhs_functions_math.cpp(608): warning C4244: '=': conversion from 'int64_t' to 'double', possible loss of data
Core\SoarKernel\src\soar_representation\rhs_functions_math.cpp(631): warning C4244: '=': conversion from 'int64_t' to 'double', possible loss of data
C:\Users\bob.marinier\git\Soar\Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\working_memory_activation.cpp(610): warning C4244: '=': conversion from 'wma_reference' to 'double', possible loss of data
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\SoarKernel\src\soar_representation\rhs.h(127): warning C4312: 'reinterpret_cast': conversion from 'int' to 'rhs_value' of greater size
Core\CLI\src\cli_soar.cpp(223): warning C4805: '==': unsafe mix of type 'T' and type 'bool' in operation
LINK : warning LNK4286: symbol '?to_string@symbol_struct@@QEAAPEAD_N0PEAD_K@Z (public: char * __cdecl symbol_struct::to_string(bool,bool,char *,unsigned __int64))' defined in 'symbol.obj' is imported by 'set_transform.obj'
LINK : warning LNK4286: symbol '?to_string@symbol_struct@@QEAAPEAD_N0PEAD_K@Z (public: char * __cdecl symbol_struct::to_string(bool,bool,char *,unsigned __int64))' defined in 'symbol.obj' is imported by 'delete_node.obj'
LINK : warning LNK4286: symbol '?to_string@symbol_struct@@QEAAPEAD_N0PEAD_K@Z (public: char * __cdecl symbol_struct::to_string(bool,bool,char *,unsigned __int64))' defined in 'symbol.obj' is imported by 'delete_tag.obj'
LINK : warning LNK4286: symbol '?to_string@symbol_struct@@QEAAPEAD_N0PEAD_K@Z (public: char * __cdecl symbol_struct::to_string(bool,bool,char *,unsigned __int64))' defined in 'symbol.obj' is imported by 'extract.obj'
LINK : warning LNK4286: symbol '?to_string@symbol_struct@@QEAAPEAD_N0PEAD_K@Z (public: char * __cdecl symbol_struct::to_string(bool,bool,char *,unsigned __int64))' defined in 'symbol.obj' is imported by 'set_tag.obj'
LINK : warning LNK4286: symbol '?to_string@symbol_struct@@QEAAPEAD_N0PEAD_K@Z (public: char * __cdecl symbol_struct::to_string(bool,bool,char *,unsigned __int64))' defined in 'symbol.obj' is imported by 'svs.obj'
LINK : warning LNK4286: symbol '?to_string@symbol_struct@@QEAAPEAD_N0PEAD_K@Z (public: char * __cdecl symbol_struct::to_string(bool,bool,char *,unsigned __int64))' defined in 'symbol.obj' is imported by 'add_node.obj'
LINK : warning LNK4286: symbol '?to_string@symbol_struct@@QEAAPEAD_N0PEAD_K@Z (public: char * __cdecl symbol_struct::to_string(bool,bool,char *,unsigned __int64))' defined in 'symbol.obj' is imported by 'copy_node.obj'
LINK : warning LNK4286: symbol '?to_string@symbol_struct@@QEAAPEAD_N0PEAD_K@Z (public: char * __cdecl symbol_struct::to_string(bool,bool,char *,unsigned __int64))' defined in 'symbol.obj' is imported by 'copy_transform.obj'
LINK : warning LNK4217: symbol '?to_string@symbol_struct@@QEAAPEAD_N0PEAD_K@Z (public: char * __cdecl symbol_struct::to_string(bool,bool,char *,unsigned __int64))' defined in 'symbol.obj' is imported by 'command.obj' in function '"public: bool __cdecl command::get_str_param(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > &)" (?get_str_param@command@@QEAA_NAEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEAV23@@Z)'
LINK : warning LNK4286: symbol '?to_string@symbol_struct@@QEAAPEAD_N0PEAD_K@Z (public: char * __cdecl symbol_struct::to_string(bool,bool,char *,unsigned __int64))' defined in 'symbol.obj' is imported by 'command_table.obj'
LINK : warning LNK4286: symbol '?to_string@symbol_struct@@QEAAPEAD_N0PEAD_K@Z (public: char * __cdecl symbol_struct::to_string(bool,bool,char *,unsigned __int64))' defined in 'symbol.obj' is imported by 'filter_table.obj'
LINK : warning LNK4286: symbol '?to_string@symbol_struct@@QEAAPEAD_N0PEAD_K@Z (public: char * __cdecl symbol_struct::to_string(bool,bool,char *,unsigned __int64))' defined in 'symbol.obj' is imported by 'soar_interface.obj'
LINK : warning LNK4286: symbol '?make_str_constant@Symbol_Manager@@QEAAPEAUsymbol_struct@@PEBD@Z (public: struct symbol_struct * __cdecl Symbol_Manager::make_str_constant(char const *))' defined in 'symbol_manager.obj' is imported by 'extract.obj'
LINK : warning LNK4217: symbol '?make_str_constant@Symbol_Manager@@QEAAPEAUsymbol_struct@@PEBD@Z (public: struct symbol_struct * __cdecl Symbol_Manager::make_str_constant(char const *))' defined in 'symbol_manager.obj' is imported by 'command.obj' in function '"public: struct wme_struct * __cdecl soar_interface::make_wme<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > >(struct symbol_struct *,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (??$make_wme@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@soar_interface@@QEAAPEAUwme_struct@@PEAUsymbol_struct@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@1@Z)'
LINK : warning LNK4286: symbol '?make_str_constant@Symbol_Manager@@QEAAPEAUsymbol_struct@@PEBD@Z (public: struct symbol_struct * __cdecl Symbol_Manager::make_str_constant(char const *))' defined in 'symbol_manager.obj' is imported by 'filter.obj'
LINK : warning LNK4286: symbol '?make_str_constant@Symbol_Manager@@QEAAPEAUsymbol_struct@@PEBD@Z (public: struct symbol_struct * __cdecl Symbol_Manager::make_str_constant(char const *))' defined in 'symbol_manager.obj' is imported by 'soar_interface.obj'
LINK : warning LNK4286: symbol '?make_str_constant@Symbol_Manager@@QEAAPEAUsymbol_struct@@PEBD@Z (public: struct symbol_struct * __cdecl Symbol_Manager::make_str_constant(char const *))' defined in 'symbol_manager.obj' is imported by 'svs.obj'
LINK : warning LNK4217: symbol '?is_string@symbol_struct@@QEAA_NXZ (public: bool __cdecl symbol_struct::is_string(void))' defined in 'sml_AgentSML.obj' is imported by 'filter_table.obj' in function '"class filter * __cdecl parse_filter_spec(class soar_interface *,struct symbol_struct *,class scene *)" (?parse_filter_spec@@YAPEAVfilter@@PEAVsoar_interface@@PEAUsymbol_struct@@PEAVscene@@@Z)'
LINK : warning LNK4286: symbol '?is_string@symbol_struct@@QEAA_NXZ (public: bool __cdecl symbol_struct::is_string(void))' defined in 'sml_AgentSML.obj' is imported by 'add_node.obj'
LINK : warning LNK4286: symbol '?is_string@symbol_struct@@QEAA_NXZ (public: bool __cdecl symbol_struct::is_string(void))' defined in 'sml_AgentSML.obj' is imported by 'copy_node.obj'
LINK : warning LNK4286: symbol '?is_string@symbol_struct@@QEAA_NXZ (public: bool __cdecl symbol_struct::is_string(void))' defined in 'sml_AgentSML.obj' is imported by 'copy_transform.obj'
LINK : warning LNK4217: symbol '?get_id_name@symbol_struct@@QEAA_NAEAV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z (public: bool __cdecl symbol_struct::get_id_name(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > &))' defined in 'sml_AgentSML.obj' is imported by 'soar_interface.obj' in function '"public: bool __cdecl soar_interface::get_vec3(struct symbol_struct *,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class Eigen::Matrix<double,3,1,0,3,1> &)" (?get_vec3@soar_interface@@QEAA_NPEAUsymbol_struct@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEAV?$Matrix@N$02$00$0A@$02$00@Eigen@@@Z)'
LINK : warning LNK4286: symbol '?get_id_name@symbol_struct@@QEAA_NAEAV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z (public: bool __cdecl symbol_struct::get_id_name(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > &))' defined in 'sml_AgentSML.obj' is imported by 'svs.obj'
LINK : warning LNK4217: symbol '?make_new_identifier@Symbol_Manager@@QEAAPEAUsymbol_struct@@DF_K_N@Z (public: struct symbol_struct * __cdecl Symbol_Manager::make_new_identifier(char,short,unsigned __int64,bool))' defined in 'symbol_manager.obj' is imported by 'soar_interface.obj' in function '"public: struct wme_struct * __cdecl soar_interface::make_id_wme(struct symbol_struct *,struct symbol_struct *)" (?make_id_wme@soar_interface@@QEAAPEAUwme_struct@@PEAUsymbol_struct@@0@Z)'
LINK : warning LNK4217: symbol '?deallocate_symbol@Symbol_Manager@@AEAAXAEAPEAUsymbol_struct@@@Z (private: void __cdecl Symbol_Manager::deallocate_symbol(struct symbol_struct * &))' defined in 'symbol_manager.obj' is imported by 'soar_interface.obj' in function '"public: __cdecl common_syms::~common_syms(void)" (??1common_syms@@QEAA@XZ)'
LINK : warning LNK4217: symbol '?make_int_constant@Symbol_Manager@@QEAAPEAUsymbol_struct@@_J@Z (public: struct symbol_struct * __cdecl Symbol_Manager::make_int_constant(__int64))' defined in 'symbol_manager.obj' is imported by 'svs.obj' in function '"public: struct wme_struct * __cdecl soar_interface::make_wme<int>(struct symbol_struct *,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,int const &)" (??$make_wme@H@soar_interface@@QEAAPEAUwme_struct@@PEAUsymbol_struct@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBH@Z)'
LINK : warning LNK4286: symbol '?make_int_constant@Symbol_Manager@@QEAAPEAUsymbol_struct@@_J@Z (public: struct symbol_struct * __cdecl Symbol_Manager::make_int_constant(__int64))' defined in 'symbol_manager.obj' is imported by 'extract.obj'
LINK : warning LNK4217: symbol '?make_float_constant@Symbol_Manager@@QEAAPEAUsymbol_struct@@N@Z (public: struct symbol_struct * __cdecl Symbol_Manager::make_float_constant(double))' defined in 'symbol_manager.obj' is imported by 'extract.obj' in function '"public: struct wme_struct * __cdecl soar_interface::make_wme<double>(struct symbol_struct *,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,double const &)" (??$make_wme@N@soar_interface@@QEAAPEAUwme_struct@@PEAUsymbol_struct@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBN@Z)'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4136): warning C4311: 'type cast': pointer truncation from 'PythonUserData *' to 'long'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4136): warning C4302: 'type cast': truncation from 'PythonUserData *' to 'long'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4144): warning C4311: 'type cast': pointer truncation from 'PythonUserData *' to 'long'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4144): warning C4302: 'type cast': truncation from 'PythonUserData *' to 'long'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4149): warning C4311: 'type cast': pointer truncation from 'PythonUserData *' to 'long'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4149): warning C4302: 'type cast': truncation from 'PythonUserData *' to 'long'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4154): warning C4311: 'type cast': pointer truncation from 'PythonUserData *' to 'long'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4154): warning C4302: 'type cast': truncation from 'PythonUserData *' to 'long'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4159): warning C4311: 'type cast': pointer truncation from 'PythonUserData *' to 'long'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4159): warning C4302: 'type cast': truncation from 'PythonUserData *' to 'long'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4164): warning C4311: 'type cast': pointer truncation from 'PythonUserData *' to 'long'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4164): warning C4302: 'type cast': truncation from 'PythonUserData *' to 'long'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4167): warning C4312: 'type cast': conversion from 'long' to 'PythonUserData *' of greater size
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4174): warning C4312: 'type cast': conversion from 'long' to 'PythonUserData *' of greater size
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4181): warning C4312: 'type cast': conversion from 'long' to 'PythonUserData *' of greater size
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4188): warning C4312: 'type cast': conversion from 'long' to 'PythonUserData *' of greater size
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4195): warning C4312: 'type cast': conversion from 'long' to 'PythonUserData *' of greater size
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4202): warning C4312: 'type cast': conversion from 'long' to 'PythonUserData *' of greater size
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4211): warning C4311: 'type cast': pointer truncation from 'PythonUserData *' to 'long'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4211): warning C4302: 'type cast': truncation from 'PythonUserData *' to 'long'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4216): warning C4311: 'type cast': pointer truncation from 'PythonUserData *' to 'long'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4216): warning C4302: 'type cast': truncation from 'PythonUserData *' to 'long'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4221): warning C4311: 'type cast': pointer truncation from 'PythonUserData *' to 'long'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4221): warning C4302: 'type cast': truncation from 'PythonUserData *' to 'long'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4226): warning C4311: 'type cast': pointer truncation from 'PythonUserData *' to 'long'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4226): warning C4302: 'type cast': truncation from 'PythonUserData *' to 'long'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4231): warning C4311: 'type cast': pointer truncation from 'PythonUserData *' to 'long'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4231): warning C4302: 'type cast': truncation from 'PythonUserData *' to 'long'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4236): warning C4311: 'type cast': pointer truncation from 'PythonUserData *' to 'long'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4236): warning C4302: 'type cast': truncation from 'PythonUserData *' to 'long'
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4239): warning C4312: 'type cast': conversion from 'long' to 'PythonUserData *' of greater size
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4246): warning C4312: 'type cast': conversion from 'long' to 'PythonUserData *' of greater size
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4253): warning C4312: 'type cast': conversion from 'long' to 'PythonUserData *' of greater size
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4260): warning C4312: 'type cast': conversion from 'long' to 'PythonUserData *' of greater size
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4267): warning C4312: 'type cast': conversion from 'long' to 'PythonUserData *' of greater size
build\Core\ClientSMLSWIG\Python\Python_sml_ClientInterface_wrap.cc(4274): warning C4312: 'type cast': conversion from 'long' to 'PythonUserData *' of greater size
C:\Users\bob.marinier\git\Soar\build\Core\ClientSMLSWIG\CSharp\CSharpCallbackByHand.h(115): warning C4312: 'type cast': conversion from 'unsigned int' to 'void *' of greater size
C:\Users\bob.marinier\git\Soar\build\Core\ClientSMLSWIG\CSharp\CSharpCallbackByHand.h(125): warning C4312: 'type cast': conversion from 'unsigned int' to 'void *' of greater size
C:\Users\bob.marinier\git\Soar\build\Core\ClientSMLSWIG\CSharp\CSharpCallbackByHand.h(184): warning C4312: 'type cast': conversion from 'int' to 'CSharpCallbackData *' of greater size
C:\Users\bob.marinier\git\Soar\build\Core\ClientSMLSWIG\CSharp\CSharpCallbackByHand.h(254): warning C4312: 'type cast': conversion from 'int' to 'CSharpCallbackData *' of greater size
C:\Users\bob.marinier\git\Soar\build\Core\ClientSMLSWIG\CSharp\CSharpCallbackByHand.h(336): warning C4312: 'type cast': conversion from 'int' to 'CSharpCallbackData *' of greater size
C:\Users\bob.marinier\git\Soar\build\Core\ClientSMLSWIG\CSharp\CSharpCallbackByHand.h(416): warning C4312: 'type cast': conversion from 'int' to 'CSharpCallbackData *' of greater size
C:\Users\bob.marinier\git\Soar\build\Core\ClientSMLSWIG\CSharp\CSharpCallbackByHand.h(488): warning C4312: 'type cast': conversion from 'int' to 'CSharpCallbackData *' of greater size
C:\Users\bob.marinier\git\Soar\build\Core\ClientSMLSWIG\CSharp\CSharpCallbackByHand.h(560): warning C4312: 'type cast': conversion from 'int' to 'CSharpCallbackData *' of greater size
C:\Users\bob.marinier\git\Soar\build\Core\ClientSMLSWIG\CSharp\CSharpCallbackByHand.h(629): warning C4312: 'type cast': conversion from 'int' to 'CSharpCallbackData *' of greater size
C:\Users\bob.marinier\git\Soar\build\Core\ClientSMLSWIG\CSharp\CSharpCallbackByHand.h(698): warning C4312: 'type cast': conversion from 'int' to 'CSharpCallbackData *' of greater size
C:\Users\bob.marinier\git\Soar\build\Core\ClientSMLSWIG\CSharp\CSharpCallbackByHand.h(783): warning C4312: 'type cast': conversion from 'int' to 'CSharpCallbackData *' of greater size
C:\Users\bob.marinier\git\Soar\build\Core\ClientSMLSWIG\CSharp\CSharpCallbackByHand.h(899): warning C4312: 'type cast': conversion from 'int' to 'CSharpCallbackData *' of greater size
C:\Users\bob.marinier\git\Soar\build\Core\ClientSMLSWIG\CSharp\CSharpCallbackByHand.h(942): warning C4312: 'type cast': conversion from 'int' to 'CSharpCallbackData *' of greater size
C:\Users\bob.marinier\git\Soar\build\Core\ClientSMLSWIG\CSharp\CSharpCallbackByHand.h(1014): warning C4312: 'type cast': conversion from 'int' to 'CSharpCallbackData *' of greater size
Java\Debugger\src\edu\umich\soar\debugger\modules\FoldingTextView.java:354: warning: [removal] Long(long) in Long has been deprecated and marked for removal
Java\Debugger\src\edu\umich\soar\debugger\modules\FoldingTextView.java:365: warning: [removal] Long(long) in Long has been deprecated and marked for removal
Java\Debugger\src\edu\umich\soar\debugger\modules\FoldingTextView.java:376: warning: [removal] Long(long) in Long has been deprecated and marked for removal
Java\Debugger\src\edu\umich\soar\debugger\modules\FoldingTextView.java:387: warning: [removal] Long(long) in Long has been deprecated and marked for removal
Java\Debugger\src\edu\umich\soar\debugger\modules\FoldingTextView.java:398: warning: [removal] Long(long) in Long has been deprecated and marked for removal
Java\Debugger\src\edu\umich\soar\debugger\modules\FoldingTextView.java:409: warning: [removal] Long(long) in Long has been deprecated and marked for removal
Java\Debugger\src\edu\umich\soar\debugger\modules\FoldingTextView.java:420: warning: [removal] Long(long) in Long has been deprecated and marked for removal
Java\Debugger\src\edu\umich\soar\debugger\modules\FoldingTextView.java:431: warning: [removal] Long(long) in Long has been deprecated and marked for removal
Java\Debugger\src\edu\umich\soar\debugger\modules\FoldingTextView.java:442: warning: [removal] Long(long) in Long has been deprecated and marked for removal
Java\Debugger\src\edu\umich\soar\debugger\modules\FoldingTextView.java:453: warning: [removal] Long(long) in Long has been deprecated and marked for removal
Java\Debugger\src\edu\umich\soar\debugger\modules\FoldingTextView.java:464: warning: [removal] Long(long) in Long has been deprecated and marked for removal
        menuItem.setData("type", new Long(TraceType.kWarning));
Java\Debugger\src\edu\umich\soar\debugger\modules\RHSBarChartView.java:78: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
Java\Debugger\src\edu\umich\soar\debugger\modules\RHSBarChartView.java:84: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
Java\Debugger\src\edu\umich\soar\debugger\modules\RHSBarChartView.java:90: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
14 warnings
C:\Users\bob.marinier\git\Soar\PerformanceTests\PerformanceTests.h(121): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\PerformanceTests\PerformanceTests.h(124): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\PerformanceTests\PerformanceTests.h(126): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\PerformanceTests\PerformanceTests.h(135): warning C4129: 'e': unrecognized character escape sequence
PerformanceTests\PerformanceTests.cpp(115): warning C4129: 'e': unrecognized character escape sequence
PerformanceTests\PerformanceTests.cpp(115): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(15): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(18): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(19): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(20): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(21): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(22): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(23): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(24): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(25): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(28): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(29): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(30): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(31): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(32): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(33): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(34): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(35): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(38): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(39): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(40): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(41): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(42): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(43): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(44): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(45): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(48): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(49): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(50): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(51): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(52): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(53): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(54): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(55): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(58): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(59): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(60): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(61): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(62): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(63): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(64): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(65): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(68): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(69): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(70): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(71): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(72): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(73): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(74): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(75): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(78): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(79): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(80): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(81): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(82): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(83): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(84): warning C4129: 'e': unrecognized character escape sequence
C:\Users\bob.marinier\git\Soar\SoarCLI\ansi_colors.h(85): warning C4129: 'e': unrecognized character escape sequence
cl : Command line warning D9025 : overriding '/W2' with '/w'
cl : Command line warning D9025 : overriding '/W2' with '/w'
LINK : warning LNK4217: symbol '??0TclSoarLib@@QEAA@PEAVKernel@sml@@@Z (public: __cdecl TclSoarLib::TclSoarLib(class sml::Kernel *))' defined in 'TclSoarLib.obj' is imported by 'main.obj' in function 'sml_InitLibrary'
LINK : warning LNK4217: symbol '??1TclSoarLib@@QEAA@XZ (public: __cdecl TclSoarLib::~TclSoarLib(void))' defined in 'TclSoarLib.obj' is imported by 'main.obj' in function '"public: void * __cdecl TclSoarLib::`scalar deleting destructor'(unsigned int)" (??_GTclSoarLib@@QEAAPEAXI@Z)'
LINK : warning LNK4217: symbol '?handle_message@TclSoarLib@@QEAA_NV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z (public: bool __cdecl TclSoarLib::handle_message(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >))' defined in 'TclSoarLib.obj' is imported by 'main.obj' in function 'sml_LibraryMessage'
Core\shared\assert.hpp(18): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'SoarAssertionException'
Core\shared\assert.hpp(18): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'SoarAssertionException'
Core\shared\assert.hpp(18): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'SoarAssertionException'
Core\shared\assert.hpp(18): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'SoarAssertionException'
Core\shared\assert.hpp(18): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'SoarAssertionException'
Core\shared\assert.hpp(18): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'SoarAssertionException'
Core\shared\assert.hpp(18): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'SoarAssertionException'
Core\shared\assert.hpp(18): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'SoarAssertionException'
Core\shared\assert.hpp(18): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'SoarAssertionException'
Core\shared\assert.hpp(18): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'SoarAssertionException'
Core\shared\assert.hpp(18): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'SoarAssertionException'
Core\shared\assert.hpp(18): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'SoarAssertionException'
Core\shared\assert.hpp(18): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'SoarAssertionException'
Core\shared\assert.hpp(18): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'SoarAssertionException'
Core\shared\assert.hpp(18): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'SoarAssertionException'
Core\shared\assert.hpp(18): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'SoarAssertionException'
Core\shared\assert.hpp(18): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'SoarAssertionException'
Core\shared\assert.hpp(18): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'SoarAssertionException'
Core\shared\assert.hpp(18): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'SoarAssertionException'
Core\shared\assert.hpp(18): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'SoarAssertionException'
Core\shared\assert.hpp(18): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'SoarAssertionException'
Core\shared\assert.hpp(18): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'SoarAssertionException'

Here's the complete output for context: build-output.txt
garfieldnate added a commit that referenced this issue Dec 27, 2022
@garfieldnate
Remove unitialized use
db9e23a 
`c` is not initialized when we check it for a value and conditionally
free a location in memory! That's undefined behavior, and could lead to
a crash.

Fixes this warning:

Core\SoarKernel\src\parsing\parser.cpp(1241) : warning C4700: uninitialized local variable 'c' used

Related to #347.
@garfieldnate garfieldnate added the infrastructure build and infrastructure label Jan 3, 2023
garfieldnate added a commit that referenced this issue Jan 6, 2023
@garfieldnate
Use octal escape sequences for ansi colors
f7c80a9 
MSVC++ doesn't understand `\e` as an escape sequence, so use `\033`
instead. Fixes this warning:

warning C4129: 'e': unrecognized character escape sequence

See #347.
@garfieldnate
Copy link
Collaborator

garfieldnate commented Mar 6, 2024 •
edited
Loading

Currently in the process of upgrading the warning levels to -Wall (/W4 on Windows). There are a good thousand warnings there. Starting with the low-hanging fruit, I'll delete the unused variables (~100).

garfieldnate added a commit that referenced this issue Mar 6, 2024
@garfieldnate
Fix more unused variable warnings
52f8bef 
Continues work on #347.
garfieldnate added a commit that referenced this issue Mar 7, 2024
@garfieldnate
Fix remaining unused variable warnings
729743d 
and enable constructor argument reordered warnings, as they are also easy to
fix and quite numerous.

Continues work on #347.
garfieldnate added a commit that referenced this issue Mar 7, 2024
@garfieldnate
Fix some initialization list reordering warnings
9f1da2c 
Continues work on #347.
@garfieldnate
Copy link
Collaborator

Work is proceeding by adding new warnings one-at-a-time here: https://github.com/SoarGroup/Soar/blob/development/SConstruct#L233. Next goal for Windows is /W2; gcc unfortunately doesn't have warning levels, but we can see the list enabled for -Wall here: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wall.

@garfieldnate
Copy link
Collaborator

Building with -Wall, outputting everything to out.txt, and then analyzing for the warnings that are left:

grep -o '\[-W[^]]*\]' out.txt | sort | uniq -c | sort -nr
 37 [-Wunused-but-set-variable]
  8 [-Wunused-private-field]
  4 [-Wuninitialized]
  4 [-Wdelete-non-abstract-non-virtual-dtor]
  2 [-Wsometimes-uninitialized]

And for -Wextra:

408 [-Wignored-qualifiers]
403 [-Wunused-parameter]
 67 [-Wsign-compare]
  2 [-Wdeprecated-copy-with-user-provided-copy]

After tackling these, we can set -Werror on *nix and then tackle Windows warnings.

garfieldnate added a commit that referenced this issue Oct 3, 2024
@garfieldnate
activate next -Wall warning to squash
fccaa0d 
See #347.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help-wanted infrastructure build and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marinier @garfieldnate