Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revision enables translation support for a streamlined the use case. Some items such
as support for multiple target languages in a single run have been omitted in favor of a
more straight forward user experience and reduced ambiguity in the scope of results.
Translator classes have been implemented using the
Configurable
pattern and the pluginloader. This introduced a new paradigm of providing configuration for a list of instances
with specific configuration required at runtime where previous
Configurable
classconfiguration has been for all instances of a specific class or module. The processing and
attribute names used to create this instance list may evolve further.
Usage
Translation function is configured in the
run
section of a configuration see the docpage in the PR for details.
New default configuration values for
run.lang_spec
andrun.translators
are in theupdated documentation and allow for backwards compatible configuration with existing runs.
There are still some existing
TODO:
comments and notes about location that may needfurther testing before landing this upstream. Most noteworthy are comments still in the
code of the
atkgen
probe that require further scrutiny to validate the attack techniqueis applied correctly.
It may be appropriate to gate this functionality as experimental for initial release, this
would required some additional guard code to ensure limited impact to report formats and
internal state.
Example
hf_RigoChat_gpu.yml:
Revisions detail
lang_spec
toen
translators
to an empty listlang_spec
probe
classes_build_prompts_triggers
is called only once during init for all implemented classes.remote
moduleTranslator
SimpleTranslator
toTranslator