Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/engt 1220 #611

Merged
merged 37 commits into from
Mar 6, 2023
Merged

Feat/engt 1220 #611

merged 37 commits into from
Mar 6, 2023

Conversation

OzanEm
Copy link
Contributor

@OzanEm OzanEm commented Feb 7, 2023 •
edited
Loading

Summary: Added nft query to the core

https://snickerdoodlelabs.atlassian.net/browse/ENGT-1220?atlOrigin=eyJpIjoiNjQ2MmUxNjZjNWQ4NDM0Yzg5MmJmMDIzOTJkMjgyNzQiLCJwIjoiaiJ9
Intended results: Nft holdings of the users should be able to be asked in a query and should return the nft holdings as insight
Potential failures:
Not getting nft holdings in the response
Not processing the nft query
Getting incorrect insights
Metrics to watch:
Should be able to get nft holdings as response
Should be able to process nft query
Returned insights should be correct

@OzanEm OzanEm requested a review from sdmuki February 7, 2023 19:32
sdmuki
sdmuki suggested changes Feb 7, 2023
View reviewed changes
documentation/sdql/EXAMPLES.md Outdated Show resolved Hide resolved
documentation/sdql/EXAMPLES.md Outdated Show resolved Hide resolved
packages/core/src/implementations/business/utilities/query/NetworkQueryEvaluator.ts Outdated Show resolved Hide resolved
@OzanEm OzanEm marked this pull request as ready for review February 9, 2023 00:56
@OzanEm OzanEm requested a review from astrimaitis February 9, 2023 17:07
sdmuki
sdmuki suggested changes Feb 9, 2023
View reviewed changes
documentation/sdql/EXAMPLES.md Outdated Show resolved Hide resolved
packages/core/src/implementations/SnickerdoodleCore.module.ts Outdated Show resolved Hide resolved
packages/core/src/implementations/business/utilities/query/NftQueryEvaluator.ts Outdated Show resolved Hide resolved
packages/core/src/implementations/business/utilities/query/NftQueryEvaluator.ts Show resolved Hide resolved
packages/core/src/implementations/business/utilities/query/NftQueryEvaluator.ts Show resolved Hide resolved
packages/core/src/implementations/business/utilities/query/NftQueryEvaluator.ts Outdated Show resolved Hide resolved
packages/core/src/implementations/business/utilities/query/NftQueryEvaluator.ts Outdated Show resolved Hide resolved
packages/core/src/implementations/business/utilities/query/Web3QueryEvaluator.ts Outdated Show resolved Hide resolved
packages/query-parser/src/interfaces/objects/AST_Web3Query.ts Outdated Show resolved Hide resolved
packages/test-harness/src/queries/query1.ts Outdated Show resolved Hide resolved
@OzanEm OzanEm requested a review from sdmuki February 10, 2023 17:28
SnickerChar
SnickerChar requested changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@SnickerChar SnickerChar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vast majority of this is just changing the naming. That's all OK. But make sure the template updates are minimized.

packages/contracts-sdk/src/implementations/ConsentContract.ts Outdated Show resolved Hide resolved
...ges/core/src/implementations/business/utilities/query/BlockchainTransactionQueryEvaluator.ts Outdated Show resolved Hide resolved
packages/core/src/implementations/business/utilities/query/Web3QueryEvaluator.ts Outdated Show resolved Hide resolved
packages/objects/src/interfaces/ISDQLQueryObject.ts Outdated Show resolved Hide resolved
packages/objects/src/interfaces/ISDQLQueryObject.ts Show resolved Hide resolved
packages/query-parser/src/implementations/business/QueryObjectFactory.ts Outdated Show resolved Hide resolved
packages/query-parser/src/implementations/business/SDQLParser.ts Outdated Show resolved Hide resolved
packages/query-parser/src/implementations/business/SDQLParser.ts Outdated Show resolved Hide resolved
packages/query-parser/src/interfaces/objects/AST_Web3Query.ts Outdated Show resolved Hide resolved
packages/query-parser/src/sampleData/avalanche4.data.ts Outdated Show resolved Hide resolved
@OzanEm OzanEm requested a review from SnickerChar February 13, 2023 17:33
@sdmuki
Copy link
Contributor

sdmuki commented Feb 14, 2023

Need to update:

  1. query-parser src/sampleData
  2. test-harness src/queries

sdmuki
sdmuki suggested changes Feb 14, 2023
View reviewed changes
packages/query-parser/src/interfaces/objects/AST_Web3Query.ts Outdated Show resolved Hide resolved
packages/query-parser/src/interfaces/objects/AST_Web3Query.ts Outdated Show resolved Hide resolved
packages/query-parser/src/interfaces/objects/AST_Web3Query.ts Outdated Show resolved Hide resolved
packages/query-parser/src/interfaces/objects/AST_Web3Query.ts Outdated Show resolved Hide resolved
packages/query-parser/src/interfaces/objects/AST_NftQuery.ts Outdated Show resolved Hide resolved
packages/query-parser/src/interfaces/objects/AST_NftQuery.ts Outdated Show resolved Hide resolved
packages/query-parser/src/interfaces/objects/AST_BlockchainTransactionQuery.ts Outdated Show resolved Hide resolved
packages/query-parser/src/implementations/business/SDQLParser.ts Outdated Show resolved Hide resolved
packages/query-parser/src/implementations/business/SDQLParser.ts Outdated Show resolved Hide resolved
SnickerChar
SnickerChar requested changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@SnickerChar SnickerChar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better. Couple of more fixes I found. Very close.

packages/core/test/unit/business/query/BlockchainTransactionQuery.test.ts Outdated Show resolved Hide resolved
packages/objects/src/interfaces/ISDQLQueryObject.ts Outdated Show resolved Hide resolved
packages/query-parser/src/implementations/business/SDQLParser.ts Outdated Show resolved Hide resolved
packages/query-parser/src/implementations/business/SDQLParser.ts Outdated Show resolved Hide resolved
@OzanEm OzanEm requested review from SnickerChar and sdmuki February 21, 2023 16:03
sdmuki
sdmuki approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@sdmuki sdmuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that network queries were changed to blockchain_transactions in the IP. So, it should not be able to parse network queries any more, am I right?

packages/query-parser/src/implementations/business/SDQLParser.ts Show resolved Hide resolved
@OzanEm
Copy link
Contributor Author

OzanEm commented Feb 21, 2023

I saw that network queries were changed to blockchain_transactions in the IP. So, it should not be able to parse network queries any more, am I right?

That was left over from previous work, I will correct that . In the end we use "network" for query name.

SnickerChar
SnickerChar approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@SnickerChar SnickerChar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it will work!

packages/objects/src/businessObjects/NftHoldings.ts Outdated Show resolved Hide resolved
@OzanEm OzanEm merged commit e69c629 into develop Mar 6, 2023
@OzanEm OzanEm deleted the feat/ENGT-1220 branch March 6, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SnickerChar SnickerChar SnickerChar approved these changes

@sdmuki sdmuki sdmuki approved these changes

@moahammadalt moahammadalt Awaiting requested review from moahammadalt

@astrimaitis astrimaitis Awaiting requested review from astrimaitis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OzanEm @sdmuki @SnickerChar