Removed unnecessary msgPayload parameter from parseRawP256Signature

SnickerdoodleLabs · Oct 30, 2024 · 9d4b85f · 9d4b85f
1 parent 7a330e8
commit 9d4b85f
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 8 deletions.
diff --git a/packages/node-utils/package.json b/packages/node-utils/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@snickerdoodlelabs/node-utils",
-  "version": "2.1.0",
+  "version": "2.1.1",
   "description": "Utilities that rely on Node APIs. They are usable in a browser with polyfills",
   "license": "MIT",
   "repository": {

diff --git a/packages/node-utils/src/implementations/CryptoUtils.ts b/packages/node-utils/src/implementations/CryptoUtils.ts
@@ -741,7 +741,6 @@ export class CryptoUtils implements ICryptoUtils {
   // returns a 64-byte ArrayBuffer containing r and s concatenated together
   public parseRawP256Signature(
     signature: P256Signature,
-    msgPayload: string,
   ): Result<P256SignatureComponents, InvalidParametersError> {
     const signatureView = this.hexToUint8Array(signature);
 
@@ -793,8 +792,6 @@ export class CryptoUtils implements ICryptoUtils {
       "",
     );
 
-    const sigAndMsgPayload = msgPayload + `r: 0x${rString}, s: 0x${sString}`;
-
     // return the signature formatted for use in crypto.subtle.verify
     return ok(
       new P256SignatureComponents(

diff --git a/packages/node-utils/src/interfaces/ICryptoUtils.ts b/packages/node-utils/src/interfaces/ICryptoUtils.ts
@@ -180,7 +180,6 @@ export interface ICryptoUtils {
 
   parseRawP256Signature(
     signature: P256Signature,
-    msgPayload: string,
   ): Result<P256SignatureComponents, InvalidParametersError>;
 
   parseClientDataJSON(

diff --git a/packages/node-utils/test/unit/CryptoUtils4.test.ts b/packages/node-utils/test/unit/CryptoUtils4.test.ts
@@ -72,8 +72,6 @@ describe("CryptoUtils Tests 4", () => {
     //   31, 110, 197, 103, 194, 3, 1, 44, 58, 255, 82, 175, 220, 80, 29, 139, 21,
     //   137, 114, 60,
     // ]);
-    const mockMsgPayload = `authenticatorData: 0x49960de5880e8c687434170f6476605b8fe4aeb9a28632c7995cf3ba831d97630500000000, clientJSONData: "{\"type\":\"webauthn.get\",\"challenge\":\"SkgtbmpSNGs4TUw3T3k3LUxsVUZtQeCNdoJu1unwpgzfenUVeSFuX221IEmGHVYEGrQ0G5A3l1CPrqa6jtHx3a4SdKeJxGRgaH2ChCnqOjcfmd6TiLc\",\"origin\":\"http://localhost:8000\",\"crossOrigin\":false}"`;
-
     const expectedValue = {
       r: "2ae4188c4bf694fa309f6d05145408b57744fa7edfadfa120143f82c8887dd45",
       s: "a3009ac7d91a9945a454011ec4e5c568a5b20727e3fc8b804142fda1d918f289",
@@ -86,7 +84,7 @@ describe("CryptoUtils Tests 4", () => {
 
     // Act
     const result = utils
-      .parseRawP256Signature(mockSignature, mockMsgPayload)
+      .parseRawP256Signature(mockSignature)
       .unwrapOr(defaultValue);
 
     // Assert