Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMB and Pluto Barycenter #97

Merged
merged 3 commits into from
Nov 14, 2024
Merged

EMB and Pluto Barycenter #97

merged 3 commits into from
Nov 14, 2024

Conversation

attipaci
Copy link
Collaborator

For most planetary systems, there isn't much of a difference between the position of the planet center and the planetary system barycenter, since either the planet has no significant satellites, or else they are tiny compared to the planet itself.

The Earth-Moon system, and the Pluto system are the exceptions to the rule. In these systems the satellites have more comparable mass to the planet, and hence the planet center is significantly offset from the system's barycenter.

Until now, NOVAS did not distinguish between Earth vs Earth-Moon Barycenter (EMB) or Pluto (planet) vs Pluto system. But planetary ephemeris providers, such as the DExxx ephemeris data from JPL do make that distrinction. Hence expand enum novas_planet to include the Earth-Moon Barycenter (NOVAS_EMB) and the Pluto system (NOVAS_PLUTO_BARYCENTER). As such the macro NOVAS_PLANETS is increased by 2 also.

Various planet enum related macros in novas.h (such as NOVAS_PLANET_NAMES_INIT) have also gained new members.

@attipaci attipaci added the enhancement New feature or request label Nov 14, 2024
@attipaci attipaci added this to the 1.2.0 milestone Nov 14, 2024
@attipaci attipaci self-assigned this Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (7296269) to head (3d11ec2).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files           8        8           
  Lines        2904     2914   +10     
  Branches      561      561           
=======================================
+ Hits         2894     2904   +10     
  Partials       10       10           
Flag Coverage Δ
unittests 99.65% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/naif.c 100.00% <100.00%> (ø)
src/novas.c 99.54% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebd169d...3d11ec2. Read the comment docs.

@attipaci attipaci marked this pull request as ready for review November 14, 2024 11:37
@attipaci attipaci merged commit 1e3d54e into main Nov 14, 2024
16 checks passed
@attipaci attipaci deleted the more-planets branch November 14, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant