Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature abstract indexer #33

Closed
wants to merge 3 commits into from

Conversation

Fdec
Copy link
Contributor

@Fdec Fdec commented May 19, 2016

No description provided.

@afoucret
Copy link
Contributor

I just took a look very quickly at this one but I think we can do a lot better than what @romainruaud have proposed in his EAV refactoring (especially on the index handler part).

I see an abstract class and many implementations where the only parts that are changed is actually the index and the type given to the constructor.

IMHO, there is a more clever way to get this done by using the DI virtual types which are a good mean to achieve this without declaring new classes for each new index handler.

I will take a look at this tomorrow or Monday and propose an implementation using virtual types.

@afoucret
Copy link
Contributor

Replaced by PR #34

@afoucret afoucret closed this May 20, 2016
botisSmile pushed a commit to botisSmile/elasticsuite that referenced this pull request Sep 8, 2021
…n-explaining-fields-and-analyzers

Explain spelling, whitespace, phonetic, etc #ESP-153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants