-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature abstract indexer #33
Conversation
I just took a look very quickly at this one but I think we can do a lot better than what @romainruaud have proposed in his EAV refactoring (especially on the index handler part). I see an abstract class and many implementations where the only parts that are changed is actually the index and the type given to the constructor. IMHO, there is a more clever way to get this done by using the DI virtual types which are a good mean to achieve this without declaring new classes for each new index handler. I will take a look at this tomorrow or Monday and propose an implementation using virtual types. |
Replaced by PR #34 |
…n-explaining-fields-and-analyzers Explain spelling, whitespace, phonetic, etc #ESP-153
No description provided.