Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use price renderer defined in layout to render product prices in auto… #207

Merged

Conversation

romainruaud
Copy link
Collaborator

…complete box.

This should fix #194 but also provide better price display into autocomplete box (special price is now properly rendered).

@afoucret
Copy link
Contributor

Hi @romainruaud, the PR is incomplete. Bundle prices are rendered as it : "0,00 €"

@romainruaud
Copy link
Collaborator Author

Hello @afoucret

Can you precise how is your bundle product configured ?

With the sample data I have following rendering for "Sprite Yoga Companion Kit", which seems good to me :

selection_157

@romainruaud romainruaud force-pushed the fix_autocomplete_price_rendering branch from 58f500f to 9ffb796 Compare November 28, 2016 10:58
@afoucret afoucret merged commit 9ffb796 into Smile-SA:2.3.x Nov 30, 2016
@afoucret
Copy link
Contributor

Was actually OK. My bad !!!

@romainruaud romainruaud deleted the fix_autocomplete_price_rendering branch January 25, 2017 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants