Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option 'ignore_above' to mapping and refactoring code #1487

Merged
merged 1 commit into from
Aug 6, 2019
Merged

add option 'ignore_above' to mapping and refactoring code #1487

merged 1 commit into from
Aug 6, 2019

Conversation

androshchuk
Copy link
Contributor

No description provided.

@romainruaud
Copy link
Collaborator

Ok, I marked some points as resolved.

What remains to be done :

  • the + which was replaced by an array_merge : I prefer to keep the old version.

  • the 256 value which is hardcoded.

Thank you

@romainruaud romainruaud merged commit 7b6cd6b into Smile-SA:2.8.x Aug 6, 2019
@rbayet rbayet mentioned this pull request Aug 21, 2019
Closed
@androshchuk androshchuk deleted the 1479-add-option-ignore_above-to-mapping branch November 27, 2019 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainruaud romainruaud romainruaud requested changes

Assignees

@romainruaud romainruaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@androshchuk @romainruaud