Don't crash if a source file doesn't exist #492
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our CI setup, we're running into a crash in slather when trying to process a profdata file:
The file that does not exist is autogenerated by Xcode for a Swift Package with a resource bundle. It cannot be found due to a complex CI setup where one machine compiles code for testing and a different machine runs the tests.
This failure happens when first parsing the coverage data and before we get a chance to ignore that file. I'd like to be able to get past the parsing step without crashing for missing files.
To resolve this, I'm checking to see if the filename from the coverage file exists on disk before calling
realpath
. If not, the path in the coverage file is used as is.