Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Sonarqube generic code coverage output #456

Merged
merged 1 commit into from
May 11, 2020

Conversation

adellibovi
Copy link
Contributor

@adellibovi adellibovi commented May 5, 2020

Hello 👋

This PR add support for Sonarqube generic code coverage xml. 😄

I am not sure what's the policy for adding new output strategy, I hope this could fit in. 🙏

Cheers,

Edited: probably this closes #258

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 95.798% when pulling ba69567 on adellibovi:master into 8f28b97 on SlatherOrg:master.

@adellibovi adellibovi changed the title Implement Sonarqube output Add support for Sonarqube generic code coverage output May 5, 2020
@adellibovi
Copy link
Contributor Author

Hi @ksuther, any chance you could look at this? 🙏

@ksuther
Copy link
Contributor

ksuther commented May 11, 2020

Thanks for the contribution! I'll take your word that it actually works with Sonarqube, as I've never used it :)

@ksuther ksuther merged commit 341f847 into SlatherOrg:master May 11, 2020
@adellibovi
Copy link
Contributor Author

Thank you @ksuther 😊 Do you know when new releases are usually planned?

@arturonaredo
Copy link

arturonaredo commented May 21, 2020

@adellibovi Do you know if this PR works with newer versions of SonarQube? since the issue linked is from 4 years ago... I bet you tested with a newer version. I'm in 8.2

Thank you for the work

@arturonaredo
Copy link

@ksuther this deserves a release indeed!! :)

@adellibovi
Copy link
Contributor Author

Thanks @arturonaredo, I tested with 8.1 😊

@arturonaredo
Copy link

arturonaredo commented May 21, 2020

I have built the gem after cloning with 'rake build' and installed with 'sudo gem install pkg/slather-2.4.8.gem'. Works for me in the meantime while the official release is done.

Working as expected.

XCode 11.4.1
SonarQube Version 8.2 (build 32929) EE

@adellibovi
Copy link
Contributor Author

@arturonaredo I wonder how fast was for you with this approach vs what Sonarqube is suggesting? To me it was almost 2 hours vs seconds :)

@arturonaredo
Copy link

@adellibovi You tell me... I was totally blocked because I got an error. After a month of other tasks I found this and... owe you a social distanced beer! moltes gràcies

@rmaqueda
Copy link

I've tried also in SonarCloud and it's working fine.

@ksuther
Copy link
Contributor

ksuther commented May 21, 2020

I'll try to do a release in the next few days. Thanks for the confirmations that it works!

@albsala
Copy link

albsala commented May 23, 2020

Let's do this guys 👍 fastlane/fastlane#16500

@Unknoob
Copy link

Unknoob commented May 25, 2020

We've been using the Cobertura.xml output for Sonar for months and it works. What's exactly the difference with this new format?

@ksuther
Copy link
Contributor

ksuther commented May 25, 2020

Released in Slather 2.4.9!

@rmaqueda
Copy link

Released in Slather 2.4.9!

Sorry for this question, maybe I'm doing something wrong with rubygems but I'm trying to update via gem update slather and I'm getting the previous version 2.4.8.

Do I need to do something extra to get the 2.4.9 version?

Thanks.

@ksuther
Copy link
Contributor

ksuther commented May 26, 2020

Sorry about that, please try again. I ran rake release but didn't realize it had hung and didn't finish.

@jaderYang
Copy link

Thanks a lot. @ksuther

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slather Cobertura report integration with Sonarqube 4.5.7
8 participants