-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Sonarqube generic code coverage output #456
Conversation
Hi @ksuther, any chance you could look at this? 🙏 |
Thanks for the contribution! I'll take your word that it actually works with Sonarqube, as I've never used it :) |
Thank you @ksuther 😊 Do you know when new releases are usually planned? |
@adellibovi Do you know if this PR works with newer versions of SonarQube? since the issue linked is from 4 years ago... I bet you tested with a newer version. I'm in 8.2 Thank you for the work |
@ksuther this deserves a release indeed!! :) |
Thanks @arturonaredo, I tested with 8.1 😊 |
I have built the gem after cloning with 'rake build' and installed with 'sudo gem install pkg/slather-2.4.8.gem'. Works for me in the meantime while the official release is done. Working as expected. XCode 11.4.1 |
@arturonaredo I wonder how fast was for you with this approach vs what Sonarqube is suggesting? To me it was almost 2 hours vs seconds :) |
@adellibovi You tell me... I was totally blocked because I got an error. After a month of other tasks I found this and... owe you a social distanced beer! moltes gràcies |
I've tried also in SonarCloud and it's working fine. |
I'll try to do a release in the next few days. Thanks for the confirmations that it works! |
Let's do this guys 👍 fastlane/fastlane#16500 |
We've been using the |
Released in Slather 2.4.9! |
Sorry for this question, maybe I'm doing something wrong with rubygems but I'm trying to update via Do I need to do something extra to get the 2.4.9 version? Thanks. |
Sorry about that, please try again. I ran |
Thanks a lot. @ksuther |
Hello 👋
This PR add support for Sonarqube generic code coverage xml. 😄
I am not sure what's the policy for adding new output strategy, I hope this could fit in. 🙏
Cheers,
Edited: probably this closes #258