Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --decimals flag for HTML and simple output #207

Merged
merged 1 commit into from
May 13, 2016
Merged

Add --decimals flag for HTML and simple output #207

merged 1 commit into from
May 13, 2016

Conversation

bootstraponline
Copy link
Member

@bootstraponline bootstraponline commented May 11, 2016

.to_f is used to avoid excessive zeros.
0.0000.to_f => 0.0

Fix #205

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 94.818% when pulling c85106d on bootstraponline:decimals into 53eb530 on SlatherOrg:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 94.827% when pulling 22d0e90 on bootstraponline:decimals into 53eb530 on SlatherOrg:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 94.827% when pulling 1923f2b on bootstraponline:decimals into 53eb530 on SlatherOrg:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 95.093% when pulling 035325d on bootstraponline:decimals into 53eb530 on SlatherOrg:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 95.093% when pulling b8898f0 on bootstraponline:decimals into 53eb530 on SlatherOrg:master.

@neonichu
Copy link
Member

Thanks for this PR, it has some conflicts with your other one (#208), could you please rebase it?

.to_f is used to avoid excessive zeros.
0.0000.to_f => 0.0

Only run coveralls on Travis
@bootstraponline
Copy link
Member Author

Rebased.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 95.093% when pulling a8a6c89 on bootstraponline:decimals into 8a21fbc on SlatherOrg:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 95.093% when pulling a8a6c89 on bootstraponline:decimals into 8a21fbc on SlatherOrg:master.

@neonichu
Copy link
Member

Awesome, thanks a lot for this PR and the other contributions, like answering some issues.

If you are interested, I would like to add you as a member to the GitHub team. This obviously comes with no obligations to contribute further in the future :)

@neonichu neonichu merged commit cbc5099 into SlatherOrg:master May 13, 2016
@bootstraponline bootstraponline deleted the decimals branch May 13, 2016 14:09
@bootstraponline
Copy link
Member Author

If you are interested, I would like to add you as a member to the GitHub team. This obviously comes with no obligations to contribute further in the future :)

Sure, I'd be happy to join.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants