Escape the link to file names properly. #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Objective C category file names often contain a plus sign (+). The link created by slather (i.e. "NSString+UnicornPoo.m.html") is working fine on the local filesystem. Stuff breaks, when the same link is used inside an application server (i.e. Tomcat running TeamCity, including the html report as build artifact). The plus is translated to a space character and the browser requests a file named "NSString UnicornPoo.m.html", which does not exist. Now the filename is encoded as "NSString%2BUnicornPoo.m.html", this does not harm local file:// links and works in TeamCity too 🌈
|
Great, thanks for the contribution. Could you please add an entry to the Changelog as well? |
|
@neonichu changelog was updated |
|
Changes Unknown when pulling c87d51b on raumfeld:fix-plus-sign-in-filenames into * on SlatherOrg:master*. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective C category file names often contain a plus sign (+). The link created by
slather (i.e. "NSString+UnicornPoo.m.html") is working fine on the local filesystem.
Stuff breaks, when the same link is used inside an application server (i.e. Tomcat
running TeamCity, including the html report as build artifact). The plus is translated
to a space character and the browser requests a file named "NSString UnicornPoo.m.html",
which does not exist.
Now the filename is encoded as "NSString%2BUnicornPoo.m.html", this does not
harm local file:// links and is working in TeamCity too 🌈