New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix onTapGesture for BPKDividedCard #2121

Merged

brunomdac merged 1 commit into main from fix-BPKDividedCard-onTapGesture

Dec 11, 2024

Contributor

iHandle commented Dec 11, 2024 •

edited

Loading

The onTapGesture was added to the wrong place, which prevented us from executing it by double-tappping a BPKDividedCard with VoiceOver on.

Check this if you have read and followed the contributing guidelines

Remember to include the following changes:

README.md
Tests
Screenshotting code
Adding a component? Remember to expose it in the main Backpack.h header file

If you are curious about how we review, please read through the code review guidelines


          Fix onTapGesture for BPKDividedCard

1fd6eff

iHandle added minor Accessibility labels

brunomdac approved these changes

View reviewed changes

brunomdac merged commit cb74882 into main

16 checks passed

brunomdac deleted the fix-BPKDividedCard-onTapGesture branch

December 11, 2024 09:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accessibility minor