Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OGM-3074: Add onContrast style for BPKSwitch #2119

Merged

Conversation

melwaraki
Copy link
Contributor

https://skyscanner.atlassian.net/browse/OGM-3074

We noticed that the background for BPKSwitch was virtually invisible when used on our dark surface colour in the search controls: https://skyscanner.slack.com/archives/C07R4T86U3Y/p1731427038598569

After a discussion with design (https://skyscanner.slack.com/archives/C07R4T86U3Y/p1731427744624449) we agreed to add a contribution to Backpack to enable this change. This decision was documented here: https://skyscanner.atlassian.net/wiki/spaces/OGM/pages/1243021492/Decision+Log+-+Backpack+Switch+Contributions

Similarly to what we have for BPKSpinner, this PR implements the new changes to add a style for BPKSwitch.
comparison-image

This change is currently only implemented in the Obj C code, but we could add it to Swift UI in this PR or a future ticket. I'd like to get your review first to see if this is the correct approach 😄

Remember to include the following changes:

If you are curious about how we review, please read through the code review guidelines

@melwaraki melwaraki added the uikit label Dec 4, 2024
@melwaraki melwaraki added the minor Non breaking change label Dec 6, 2024
@brunomdac brunomdac merged commit d9a8128 into Skyscanner:main Dec 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Non breaking change uikit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants