[MUON-543] BPKGraphic promo sponsored #2073

darioroa · 2024-10-03T14:42:16Z

Update sponsored BPKGraphic Promo

Updates designs for the graphic promo sponsored
Updates the API to be init (as opposed to the previous modifier approach). This is a breaking change, so let's discuss (though to our knowledge this component isn't being used yet).

Before (bottom aligned)	Before (top aligned)	After

Check this if you have read and followed the contributing guidelines

Remember to include the following changes:

README.md
Tests
Screenshotting code
Adding a component? Remember to expose it in the main Backpack.h header file

If you are curious about how we review, please read through the code review guidelines

Remove modifier approach

darioroa · 2024-10-04T09:01:42Z

Backpack-SwiftUI/GraphicPromo/Classes/BPKGraphicPromo.swift

@@ -70,6 +70,29 @@ public struct BPKGraphicPromo: View {
        self.verticalAlignment = verticalAlignment
    }

+    public init(


Probably the most significant breaking change. We want a direct init for the sponsored version, as some of the fields from the organic version are not used in the sponsored one.

looks good!

darioroa · 2024-10-04T09:02:32Z

Backpack-SwiftUI/GraphicPromo/Classes/BPKGraphicPromo.swift

+            if let sponsor {
+                sponsorContentView(sponsor)
+            } else {
+                Spacer()
+                VStack(alignment: .leading, spacing: .md) {
+                    if verticalAlignment == .bottom {
+                        Spacer()


Hard fork for the content of organic vs. sponsored

AxelCB

Left some comments from initial review 😄

Backpack-SwiftUI/GraphicPromo/Classes/BPKGraphicPromo.swift

github-actions · 2024-10-04T09:59:31Z

Snapshots were updated. Please verify the changes match the expected layout.

' D Backpack-SwiftUI/Tests/BannerAlert/Snapshots/BPKBannerAlertTests/test_multilineBannerAlert.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/BannerAlert/Snapshots/BPKBannerAlertTests/test_multilineBannerAlert.light-mode.png'%0A' D Backpack-SwiftUI/Tests/BannerAlert/Snapshots/BPKBannerAlertTests/test_multilineBannerAlert.rtl.png'%0A' M Backpack-SwiftUI/Tests/GraphicPromo/Snapshots/BPKGraphicPromoTests/test_sponsored.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/GraphicPromo/Snapshots/BPKGraphicPromoTests/test_sponsored.light-mode.png'%0A' M Backpack-SwiftUI/Tests/GraphicPromo/Snapshots/BPKGraphicPromoTests/test_sponsored.rtl.png'%0A' M Backpack-SwiftUI/Tests/GraphicPromo/Snapshots/BPKGraphicPromoTests/test_sponsored_a11y.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/GraphicPromo/Snapshots/BPKGraphicPromoTests/test_sponsored_a11y.light-mode.png'%0A' M Backpack-SwiftUI/Tests/GraphicPromo/Snapshots/BPKGraphicPromoTests/test_sponsored_a11y.rtl.png'%0A' M Backpack-SwiftUI/Tests/GraphicPromo/Snapshots/BPKGraphicPromoTests/test_sponsored_longText.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/GraphicPromo/Snapshots/BPKGraphicPromoTests/test_sponsored_longText.light-mode.png'%0A' M Backpack-SwiftUI/Tests/GraphicPromo/Snapshots/BPKGraphicPromoTests/test_sponsored_longText.rtl.png'%0A' D Backpack-SwiftUI/Tests/NavigationTabGroup/Snapshots/BPKNavigationTabGroupTests/test_dark.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/NavigationTabGroup/Snapshots/BPKNavigationTabGroupTests/test_dark.light-mode.png'%0A' D Backpack-SwiftUI/Tests/NavigationTabGroup/Snapshots/BPKNavigationTabGroupTests/test_dark.rtl.png'%0A' D Backpack-SwiftUI/Tests/NavigationTabGroup/Snapshots/BPKNavigationTabGroupTests/test_default.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/NavigationTabGroup/Snapshots/BPKNavigationTabGroupTests/test_default.light-mode.png'%0A' D Backpack-SwiftUI/Tests/NavigationTabGroup/Snapshots/BPKNavigationTabGroupTests/test_default.rtl.png'%0A' D Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_clearableField_withPrefixIcon.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_clearableField_withPrefixIcon.light-mode.png'%0A' D Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_clearableField_withPrefixIcon.rtl.png'%0A' D Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_disabledField_withCustomPrefixText.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_disabledField_withCustomPrefixText.light-mode.png'%0A' D Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_disabledField_withCustomPrefixText.rtl.png'%0A' D Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_disabledField_withPrefixIcon.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_disabledField_withPrefixIcon.light-mode.png'%0A' D Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_disabledField_withPrefixIcon.rtl.png'%0A' D Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_errorField_withCustomPrefixText.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_errorField_withCustomPrefixText.light-mode.png'%0A' D Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_errorField_withCustomPrefixText.rtl.png'%0A' D Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_errorField_withPrefixIcon.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_errorField_withPrefixIcon.light-mode.png'%0A' D Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_errorField_withPrefixIcon.rtl.png'%0A' D Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_validField_withCustomPrefixText.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_validField_withCustomPrefixText.light-mode.png'%0A' D Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_validField_withCustomPrefixText.rtl.png'%0A' D Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_validField_withPrefixIcon.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_validField_withPrefixIcon.light-mode.png'%0A' D Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_validField_withPrefixIcon.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_clearableField_withCustomPrefixText.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_clearableField_withCustomPrefixText.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_clearableField_withCustomPrefixText.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_clearableField_withPrefixIcon.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_clearableField_withPrefixIcon.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_clearableField_withPrefixIcon.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_defaultSettings_withCustomPrefixText.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_defaultSettings_withCustomPrefixText.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_defaultSettings_withCustomPrefixText.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_defaultSettings_withPrefixIcon.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_defaultSettings_withPrefixIcon.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_defaultSettings_withPrefixIcon.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_disabledField_withCustomPrefixText.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_disabledField_withCustomPrefixText.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_disabledField_withCustomPrefixText.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_disabledField_withPrefixIcon.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_disabledField_withPrefixIcon.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_disabledField_withPrefixIcon.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_emptyField_withCustomPrefixText.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_emptyField_withCustomPrefixText.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_emptyField_withCustomPrefixText.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_emptyField_withPrefixIcon.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_emptyField_withPrefixIcon.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_emptyField_withPrefixIcon.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_errorField_withCustomPrefixText.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_errorField_withCustomPrefixText.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_errorField_withCustomPrefixText.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_errorField_withPrefixIcon.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_errorField_withPrefixIcon.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_errorField_withPrefixIcon.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_validField_withCustomPrefixText.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_validField_withCustomPrefixText.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_validField_withCustomPrefixText.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_validField_withPrefixIcon.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_validField_withPrefixIcon.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_validField_withPrefixIcon.rtl.png'

darioroa · 2024-10-09T08:59:59Z

Thanks for the ✅ @brunomdac , we are good to merge now.
Just to keep you in the loop, we plan on developing the iPad version over here: https://skyscanner.atlassian.net/browse/MUON-577

Dario Roa added 5 commits September 25, 2024 14:36

[MUON-543] Update BPKWrapper Sponsored version

e827698

[MUON-543] Add long text snapshot test

e6b9fb0

Merge branch 'main' into muon/MUON-543_graphic_promo_sponsored

7378960

Alternate init for sponsored version

5930f81

Remove modifier approach

Update snapshot tests

ee591ae

darioroa added the major Breaking change label Oct 3, 2024

darioroa self-assigned this Oct 3, 2024

darioroa changed the title ~~Muon/muon 543 graphic promo sponsored~~ [MUON-543] BPKGraphic promo sponsored Oct 3, 2024

Dario Roa and others added 2 commits October 4, 2024 10:12

Record snapshots

2637999

Updated snapshots

943837d

darioroa commented Oct 4, 2024

View reviewed changes

AxelCB reviewed Oct 4, 2024

View reviewed changes

Dario Roa and others added 4 commits October 4, 2024 11:30

PR Updates

e20f69b

Record snapshots

92cc002

Record snapshots

087d72d

Updated snapshots

b007a7b

Skyscanner deleted a comment from github-actions bot Oct 4, 2024

darioroa closed this Oct 4, 2024

darioroa reopened this Oct 4, 2024

darioroa added bpk swiftui labels Oct 7, 2024

brunomdac approved these changes Oct 7, 2024

View reviewed changes

frugoman merged commit 297d7ca into main Oct 9, 2024
15 checks passed

frugoman deleted the muon/MUON-543_graphic_promo_sponsored branch October 9, 2024 14:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MUON-543] BPKGraphic promo sponsored #2073

[MUON-543] BPKGraphic promo sponsored #2073

darioroa commented Oct 3, 2024 •

edited

Loading

darioroa Oct 4, 2024

frugoman Oct 9, 2024

darioroa Oct 4, 2024

AxelCB left a comment

github-actions bot commented Oct 4, 2024

darioroa commented Oct 9, 2024

[MUON-543] BPKGraphic promo sponsored #2073

[MUON-543] BPKGraphic promo sponsored #2073

Conversation

darioroa commented Oct 3, 2024 • edited Loading

Update sponsored BPKGraphic Promo

darioroa Oct 4, 2024

Choose a reason for hiding this comment

frugoman Oct 9, 2024

Choose a reason for hiding this comment

darioroa Oct 4, 2024

Choose a reason for hiding this comment

AxelCB left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 4, 2024

Snapshots were updated. Please verify the changes match the expected layout.

darioroa commented Oct 9, 2024

darioroa commented Oct 3, 2024 •

edited

Loading