Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add peeking bottom sheet functionality #2017

Merged
merged 7 commits into from
Jul 26, 2024
Merged

Add peeking bottom sheet functionality #2017

merged 7 commits into from
Jul 26, 2024

Conversation

frugoman
Copy link
Contributor

This pull request adds a new feature to the codebase that allows the user to show a partially visible bottom sheet that can be expanded by dragging. The BottomSheetExampleView now includes a button to show the peeking bottom sheet. The ContentFitBottomSheet struct has been updated to include a peekHeight parameter, allowing the user to specify the initial height of the peeking bottom sheet.

The code changes introduce a new feature to add peeking bottom sheet functionality. This allows the user to show a partially visible bottom sheet that can be expanded by dragging. The `BottomSheetExampleView` now includes a button to show the peeking bottom sheet. The `ContentFitBottomSheet` struct has been updated to include a `peekHeight` parameter, allowing the user to specify the initial height of the peeking bottom sheet.
@frugoman frugoman changed the title Add peeking bottom sheet functionality [DO NOT MERGE] Add peeking bottom sheet functionality Jul 22, 2024
@frugoman frugoman marked this pull request as draft July 22, 2024 14:47
@frugoman frugoman added swiftui minor Non breaking change labels Jul 25, 2024
The code changes update the presentation background interaction in BPKBottomSheet.swift to use the `PresentationBackgroundInteraction.enabled` enum value instead of the deprecated `.enabled` shorthand. This ensures compatibility with the latest SwiftUI version and improves the overall functionality of the bottom sheet component.
@frugoman frugoman marked this pull request as ready for review July 25, 2024 12:57
@frugoman frugoman enabled auto-merge (squash) July 26, 2024 14:54
@frugoman frugoman merged commit 0da350e into main Jul 26, 2024
14 checks passed
@frugoman frugoman deleted the bottomsheet_peeking branch July 26, 2024 15:28
@frugoman frugoman changed the title [DO NOT MERGE] Add peeking bottom sheet functionality Add peeking bottom sheet functionality Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Non breaking change swiftui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants