-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AI-600: Fix TextArea frame #2001
Conversation
Snapshots were updated. Please verify the changes match the expected layout.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for fixing!
TextArea
frame'sminHeight
is set to the equivalent of 3 lines, but this does not take into consideration the padding added between theBPKText
/TextEditor
and the frame. The incorrectminHeight
sometimes activates the scrolling behaviour of theTextEditor
when a third line is added, and after a fourth line is added, it starts to expand instead of scrolling. This fix ensures that theTextArea
expands its height in all cases.Remember to include the following changes:
README.md
Backpack.h
header fileIf you are curious about how we review, please read through the code review guidelines