-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DON-594: Add fitsInsideBorder property to Outline #1999
Conversation
Snapshots were updated. Please verify the changes match the expected layout.
|
RoundedRectangle(cornerRadius: cornerRadius) | ||
.stroke(Color(color), lineWidth: lineWidth) | ||
Group { | ||
if fitsInsideBorder { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we need this check, lets always do this!
Snapshots were updated. Please verify the changes match the expected layout.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! thanks for updating all the use cases!!
Remember to include the following changes:
README.md
Backpack.h
header fileIf you are curious about how we review, please read through the code review guidelines