Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DON-594: Add fitsInsideBorder property to Outline #1999

Merged
merged 8 commits into from
Jul 2, 2024

Conversation

yurareutskiy
Copy link
Contributor

Remember to include the following changes:

If you are curious about how we review, please read through the code review guidelines

Copy link
Contributor

github-actions bot commented Jul 1, 2024

Snapshots were updated. Please verify the changes match the expected layout.

' D Backpack-SwiftUI/Tests/NavigationTabGroup/Snapshots/BPKNavigationTabGroupTests/test_dark.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/NavigationTabGroup/Snapshots/BPKNavigationTabGroupTests/test_dark.light-mode.png'%0A' D Backpack-SwiftUI/Tests/NavigationTabGroup/Snapshots/BPKNavigationTabGroupTests/test_dark.rtl.png'%0A' D Backpack-SwiftUI/Tests/NavigationTabGroup/Snapshots/BPKNavigationTabGroupTests/test_default.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/NavigationTabGroup/Snapshots/BPKNavigationTabGroupTests/test_default.light-mode.png'%0A' D Backpack-SwiftUI/Tests/NavigationTabGroup/Snapshots/BPKNavigationTabGroupTests/test_default.rtl.png'%0A' M Backpack-SwiftUI/Tests/Select/Snapshots/SelectTests/test_defaultSettings.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/Select/Snapshots/SelectTests/test_defaultSettings.light-mode.png'%0A' M Backpack-SwiftUI/Tests/Select/Snapshots/SelectTests/test_defaultSettings.rtl.png'%0A' M Backpack-SwiftUI/Tests/Select/Snapshots/SelectTests/test_disabledState.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/Select/Snapshots/SelectTests/test_disabledState.light-mode.png'%0A' M Backpack-SwiftUI/Tests/Select/Snapshots/SelectTests/test_disabledState.rtl.png'%0A' M Backpack-SwiftUI/Tests/Select/Snapshots/SelectTests/test_emptyOptions.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/Select/Snapshots/SelectTests/test_emptyOptions.light-mode.png'%0A' M Backpack-SwiftUI/Tests/Select/Snapshots/SelectTests/test_emptyOptions.rtl.png'%0A' M Backpack-SwiftUI/Tests/Select/Snapshots/SelectTests/test_errorState.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/Select/Snapshots/SelectTests/test_errorState.light-mode.png'%0A' M Backpack-SwiftUI/Tests/Select/Snapshots/SelectTests/test_errorState.rtl.png'%0A' M Backpack-SwiftUI/Tests/Select/Snapshots/SelectTests/test_selectOutOfBoundsItem.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/Select/Snapshots/SelectTests/test_selectOutOfBoundsItem.light-mode.png'%0A' M Backpack-SwiftUI/Tests/Select/Snapshots/SelectTests/test_selectOutOfBoundsItem.rtl.png'%0A' M Backpack-SwiftUI/Tests/Select/Snapshots/SelectTests/test_selectSecondItem.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/Select/Snapshots/SelectTests/test_selectSecondItem.light-mode.png'%0A' M Backpack-SwiftUI/Tests/Select/Snapshots/SelectTests/test_selectSecondItem.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_clearableField_withCustomPrefixText.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_clearableField_withCustomPrefixText.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_clearableField_withCustomPrefixText.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_clearableField_withPrefixIcon.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_clearableField_withPrefixIcon.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_clearableField_withPrefixIcon.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_defaultSettings_withCustomPrefixText.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_defaultSettings_withCustomPrefixText.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_defaultSettings_withCustomPrefixText.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_defaultSettings_withPrefixIcon.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_defaultSettings_withPrefixIcon.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_defaultSettings_withPrefixIcon.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_disabledField_withCustomPrefixText.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_disabledField_withCustomPrefixText.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_disabledField_withCustomPrefixText.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_disabledField_withPrefixIcon.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_disabledField_withPrefixIcon.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_disabledField_withPrefixIcon.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_emptyField_withCustomPrefixText.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_emptyField_withCustomPrefixText.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_emptyField_withCustomPrefixText.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_emptyField_withPrefixIcon.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_emptyField_withPrefixIcon.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_emptyField_withPrefixIcon.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_errorField_withCustomPrefixText.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_errorField_withCustomPrefixText.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_errorField_withCustomPrefixText.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_errorField_withPrefixIcon.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_errorField_withPrefixIcon.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_errorField_withPrefixIcon.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_validField_withCustomPrefixText.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_validField_withCustomPrefixText.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_validField_withCustomPrefixText.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_validField_withPrefixIcon.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_validField_withPrefixIcon.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_validField_withPrefixIcon.rtl.png'

@yurareutskiy yurareutskiy added swiftui minor Non breaking change labels Jul 1, 2024
@yurareutskiy yurareutskiy marked this pull request as ready for review July 1, 2024 09:37
RoundedRectangle(cornerRadius: cornerRadius)
.stroke(Color(color), lineWidth: lineWidth)
Group {
if fitsInsideBorder {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we need this check, lets always do this!

Copy link
Contributor

github-actions bot commented Jul 2, 2024

Snapshots were updated. Please verify the changes match the expected layout.

' M Backpack-SwiftUI/Tests/AppSearchModal/Snapshots/BPKAppSearchModalTests/test_withContent.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/AppSearchModal/Snapshots/BPKAppSearchModalTests/test_withContent.light-mode.png'%0A' M Backpack-SwiftUI/Tests/AppSearchModal/Snapshots/BPKAppSearchModalTests/test_withContent.rtl.png'%0A' M Backpack-SwiftUI/Tests/AppSearchModal/Snapshots/BPKAppSearchModalTests/test_withContentInputStateClear.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/AppSearchModal/Snapshots/BPKAppSearchModalTests/test_withContentInputStateClear.light-mode.png'%0A' M Backpack-SwiftUI/Tests/AppSearchModal/Snapshots/BPKAppSearchModalTests/test_withContentInputStateClear.rtl.png'%0A' M Backpack-SwiftUI/Tests/AppSearchModal/Snapshots/BPKAppSearchModalTests/test_withContentWhenPrefixIsCustomText.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/AppSearchModal/Snapshots/BPKAppSearchModalTests/test_withContentWhenPrefixIsCustomText.light-mode.png'%0A' M Backpack-SwiftUI/Tests/AppSearchModal/Snapshots/BPKAppSearchModalTests/test_withContentWhenPrefixIsCustomText.rtl.png'%0A' M Backpack-SwiftUI/Tests/AppSearchModal/Snapshots/BPKAppSearchModalTests/test_withContentWhenPrefixIsIcon.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/AppSearchModal/Snapshots/BPKAppSearchModalTests/test_withContentWhenPrefixIsIcon.light-mode.png'%0A' M Backpack-SwiftUI/Tests/AppSearchModal/Snapshots/BPKAppSearchModalTests/test_withContentWhenPrefixIsIcon.rtl.png'%0A' M Backpack-SwiftUI/Tests/AppSearchModal/Snapshots/BPKAppSearchModalTests/test_withLoading.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/AppSearchModal/Snapshots/BPKAppSearchModalTests/test_withLoading.light-mode.png'%0A' M Backpack-SwiftUI/Tests/AppSearchModal/Snapshots/BPKAppSearchModalTests/test_withLoading.rtl.png'%0A' M Backpack-SwiftUI/Tests/Badge/Snapshots/BPKBadgeTests/test_allBadgesWithIcon.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/Badge/Snapshots/BPKBadgeTests/test_allBadgesWithIcon.light-mode.png'%0A' M Backpack-SwiftUI/Tests/Badge/Snapshots/BPKBadgeTests/test_allBadgesWithIcon.rtl.png'%0A' M Backpack-SwiftUI/Tests/Badge/Snapshots/BPKBadgeTests/test_allBadgesWithoutIcon.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/Badge/Snapshots/BPKBadgeTests/test_allBadgesWithoutIcon.light-mode.png'%0A' M Backpack-SwiftUI/Tests/Badge/Snapshots/BPKBadgeTests/test_allBadgesWithoutIcon.rtl.png'%0A' M Backpack-SwiftUI/Tests/Chip/Snapshots/BPKChipTests/test_chipDropdown.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/Chip/Snapshots/BPKChipTests/test_chipDropdown.light-mode.png'%0A' M Backpack-SwiftUI/Tests/Chip/Snapshots/BPKChipTests/test_chipDropdown.rtl.png'%0A' M Backpack-SwiftUI/Tests/Chip/Snapshots/BPKChipTests/test_chipSelected.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/Chip/Snapshots/BPKChipTests/test_chipSelected.light-mode.png'%0A' M Backpack-SwiftUI/Tests/Chip/Snapshots/BPKChipTests/test_chipSelected.rtl.png'%0A' M Backpack-SwiftUI/Tests/Chip/Snapshots/BPKChipTests/test_chipWithIcon.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/Chip/Snapshots/BPKChipTests/test_chipWithIcon.light-mode.png'%0A' M Backpack-SwiftUI/Tests/Chip/Snapshots/BPKChipTests/test_chipWithIcon.rtl.png'%0A' M Backpack-SwiftUI/Tests/Chip/Snapshots/BPKChipTests/test_textChip.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/Chip/Snapshots/BPKChipTests/test_textChip.light-mode.png'%0A' M Backpack-SwiftUI/Tests/Chip/Snapshots/BPKChipTests/test_textChip.rtl.png'%0A' M Backpack-SwiftUI/Tests/ChipGroup/Snapshots/BPKChipGroupTests/test_multipleSelect_railChips_default.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/ChipGroup/Snapshots/BPKChipGroupTests/test_multipleSelect_railChips_default.light-mode.png'%0A' M Backpack-SwiftUI/Tests/ChipGroup/Snapshots/BPKChipGroupTests/test_multipleSelect_railChips_default.rtl.png'%0A' M Backpack-SwiftUI/Tests/ChipGroup/Snapshots/BPKChipGroupTests/test_multipleSelect_railWithStickyChips_default.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/ChipGroup/Snapshots/BPKChipGroupTests/test_multipleSelect_railWithStickyChips_default.light-mode.png'%0A' M Backpack-SwiftUI/Tests/ChipGroup/Snapshots/BPKChipGroupTests/test_multipleSelect_railWithStickyChips_default.rtl.png'%0A' M Backpack-SwiftUI/Tests/ChipGroup/Snapshots/BPKChipGroupTests/test_multipleSelect_wrapChips_onDark.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/ChipGroup/Snapshots/BPKChipGroupTests/test_multipleSelect_wrapChips_onDark.light-mode.png'%0A' M Backpack-SwiftUI/Tests/ChipGroup/Snapshots/BPKChipGroupTests/test_multipleSelect_wrapChips_onDark.rtl.png'%0A' M Backpack-SwiftUI/Tests/ChipGroup/Snapshots/BPKChipGroupTests/test_singleSelect_railChips_default.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/ChipGroup/Snapshots/BPKChipGroupTests/test_singleSelect_railChips_default.light-mode.png'%0A' M Backpack-SwiftUI/Tests/ChipGroup/Snapshots/BPKChipGroupTests/test_singleSelect_railChips_default.rtl.png'%0A' M Backpack-SwiftUI/Tests/ChipGroup/Snapshots/BPKChipGroupTests/test_singleSelect_wrapChips_onDark.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/ChipGroup/Snapshots/BPKChipGroupTests/test_singleSelect_wrapChips_onDark.light-mode.png'%0A' M Backpack-SwiftUI/Tests/ChipGroup/Snapshots/BPKChipGroupTests/test_singleSelect_wrapChips_onDark.rtl.png'%0A' M Backpack-SwiftUI/Tests/ImageGalleryGrid/Snapshots/ImageGalleryGridTests/test_imageGalleryChipGrid.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/ImageGalleryGrid/Snapshots/ImageGalleryGridTests/test_imageGalleryChipGrid.light-mode.png'%0A' M Backpack-SwiftUI/Tests/ImageGalleryGrid/Snapshots/ImageGalleryGridTests/test_imageGalleryChipGrid.rtl.png'%0A' M Backpack-SwiftUI/Tests/NavigationTab/Snapshots/BPKNavigationTabGroupTests/test_dark.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/NavigationTab/Snapshots/BPKNavigationTabGroupTests/test_dark.light-mode.png'%0A' M Backpack-SwiftUI/Tests/NavigationTab/Snapshots/BPKNavigationTabGroupTests/test_dark.rtl.png'%0A' M Backpack-SwiftUI/Tests/NavigationTab/Snapshots/BPKNavigationTabGroupTests/test_default.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/NavigationTab/Snapshots/BPKNavigationTabGroupTests/test_default.light-mode.png'%0A' M Backpack-SwiftUI/Tests/NavigationTab/Snapshots/BPKNavigationTabGroupTests/test_default.rtl.png'%0A' M Backpack-SwiftUI/Tests/NavigationTab/Snapshots/BPKNavigationTabTests/test_navigationTabSelected.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/NavigationTab/Snapshots/BPKNavigationTabTests/test_navigationTabSelected.light-mode.png'%0A' M Backpack-SwiftUI/Tests/NavigationTab/Snapshots/BPKNavigationTabTests/test_navigationTabSelected.rtl.png'%0A' M Backpack-SwiftUI/Tests/NavigationTab/Snapshots/BPKNavigationTabTests/test_navigationTabWithIcon.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/NavigationTab/Snapshots/BPKNavigationTabTests/test_navigationTabWithIcon.light-mode.png'%0A' M Backpack-SwiftUI/Tests/NavigationTab/Snapshots/BPKNavigationTabTests/test_navigationTabWithIcon.rtl.png'%0A' M Backpack-SwiftUI/Tests/NavigationTab/Snapshots/BPKNavigationTabTests/test_textNavigationTab.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/NavigationTab/Snapshots/BPKNavigationTabTests/test_textNavigationTab.light-mode.png'%0A' M Backpack-SwiftUI/Tests/NavigationTab/Snapshots/BPKNavigationTabTests/test_textNavigationTab.rtl.png'%0A' D Backpack-SwiftUI/Tests/NavigationTabGroup/Snapshots/BPKNavigationTabGroupTests/test_dark.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/NavigationTabGroup/Snapshots/BPKNavigationTabGroupTests/test_dark.light-mode.png'%0A' D Backpack-SwiftUI/Tests/NavigationTabGroup/Snapshots/BPKNavigationTabGroupTests/test_dark.rtl.png'%0A' D Backpack-SwiftUI/Tests/NavigationTabGroup/Snapshots/BPKNavigationTabGroupTests/test_default.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/NavigationTabGroup/Snapshots/BPKNavigationTabGroupTests/test_default.light-mode.png'%0A' D Backpack-SwiftUI/Tests/NavigationTabGroup/Snapshots/BPKNavigationTabGroupTests/test_default.rtl.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_accessibility.a11y.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_clearableField_withCustomPrefixText.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_clearableField_withCustomPrefixText.light-mode.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_clearableField_withCustomPrefixText.rtl.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_clearableField_withPrefixIcon.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_clearableField_withPrefixIcon.light-mode.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_clearableField_withPrefixIcon.rtl.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_defaultSettings_withCustomPrefixText.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_defaultSettings_withCustomPrefixText.light-mode.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_defaultSettings_withCustomPrefixText.rtl.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_defaultSettings_withPrefixIcon.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_defaultSettings_withPrefixIcon.light-mode.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_defaultSettings_withPrefixIcon.rtl.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_disabledField_withCustomPrefixText.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_disabledField_withCustomPrefixText.light-mode.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_disabledField_withCustomPrefixText.rtl.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_disabledField_withPrefixIcon.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_disabledField_withPrefixIcon.light-mode.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_disabledField_withPrefixIcon.rtl.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_emptyField_withCustomPrefixText.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_emptyField_withCustomPrefixText.light-mode.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_emptyField_withCustomPrefixText.rtl.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_emptyField_withPrefixIcon.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_emptyField_withPrefixIcon.light-mode.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_emptyField_withPrefixIcon.rtl.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_errorField_withCustomPrefixText.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_errorField_withCustomPrefixText.light-mode.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_errorField_withCustomPrefixText.rtl.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_errorField_withPrefixIcon.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_errorField_withPrefixIcon.light-mode.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_errorField_withPrefixIcon.rtl.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_validField_withCustomPrefixText.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_validField_withCustomPrefixText.light-mode.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_validField_withCustomPrefixText.rtl.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_validField_withPrefixIcon.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_validField_withPrefixIcon.light-mode.png'%0A' M Backpack-SwiftUI/Tests/SearchInputSummary/Snapshots/BPKSearchInputSummaryTests/test_validField_withPrefixIcon.rtl.png'%0A' M Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_clearableField.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_clearableField.light-mode.png'%0A' M Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_clearableField.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_clearableField_withCustomPrefixText.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_clearableField_withCustomPrefixText.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_clearableField_withCustomPrefixText.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_clearableField_withPrefixIcon.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_clearableField_withPrefixIcon.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_clearableField_withPrefixIcon.rtl.png'%0A' M Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_defaultSettings.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_defaultSettings.light-mode.png'%0A' M Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_defaultSettings.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_defaultSettings_withCustomPrefixText.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_defaultSettings_withCustomPrefixText.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_defaultSettings_withCustomPrefixText.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_defaultSettings_withPrefixIcon.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_defaultSettings_withPrefixIcon.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_defaultSettings_withPrefixIcon.rtl.png'%0A' M Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_disabledField.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_disabledField.light-mode.png'%0A' M Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_disabledField.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_disabledField_withCustomPrefixText.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_disabledField_withCustomPrefixText.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_disabledField_withCustomPrefixText.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_disabledField_withPrefixIcon.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_disabledField_withPrefixIcon.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_disabledField_withPrefixIcon.rtl.png'%0A' M Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_emptyField.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_emptyField.light-mode.png'%0A' M Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_emptyField.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_emptyField_withCustomPrefixText.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_emptyField_withCustomPrefixText.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_emptyField_withCustomPrefixText.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_emptyField_withPrefixIcon.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_emptyField_withPrefixIcon.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_emptyField_withPrefixIcon.rtl.png'%0A' M Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_errorField.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_errorField.light-mode.png'%0A' M Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_errorField.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_errorField_withCustomPrefixText.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_errorField_withCustomPrefixText.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_errorField_withCustomPrefixText.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_errorField_withPrefixIcon.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_errorField_withPrefixIcon.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_errorField_withPrefixIcon.rtl.png'%0A' M Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_validField.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_validField.light-mode.png'%0A' M Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_validField.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_validField_withCustomPrefixText.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_validField_withCustomPrefixText.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_validField_withCustomPrefixText.rtl.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_validField_withPrefixIcon.dark-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_validField_withPrefixIcon.light-mode.png'%0A' D Backpack-SwiftUI/Tests/TextField/Snapshots/BPKTextFieldTests/test_validField_withPrefixIcon.rtl.png'

Copy link
Contributor

@frugoman frugoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks for updating all the use cases!!

@frugoman frugoman merged commit 62c729e into main Jul 2, 2024
14 checks passed
@frugoman frugoman deleted the donburi/DON-594_fix_outline_borders branch July 2, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Non breaking change swiftui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants