Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KOA-5475 Badges semantic color #1425

Merged
merged 4 commits into from
Sep 21, 2022
Merged

Conversation

frugoman
Copy link
Contributor

@frugoman frugoman commented Sep 15, 2022

Badges

update Badges to use semantic colours

New styles

Light mode Dark mode
Simulator Screen Shot - iPhone 13 mini - 2022-09-15 at 16 46 15 Simulator Screen Shot - iPhone 13 mini - 2022-09-15 at 16 46 52

Remember to include the following changes:

If you are curious about how we review, please read through the code review guidelines

@frugoman frugoman changed the title badges using semantic colours KOA-5475 Badges semantic color Sep 15, 2022
@frugoman frugoman added the minor Non breaking change label Sep 15, 2022
@frugoman frugoman enabled auto-merge (squash) September 15, 2022 15:50
Copy link
Contributor

@gert-janvercauteren gert-janvercauteren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SwiftUI and UIKit badges don't seem to match. A previous white badge is now blueish?
Could you also update the docs screenshots please :D

Copy link
Contributor

@gert-janvercauteren gert-janvercauteren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a .critical that is the same to .destructive and deprecate the destructive one? Then we can kill 2 birds with one stone :D

@frugoman frugoman merged commit ab9e115 into main Sep 21, 2022
@frugoman frugoman deleted the koala/KOA-5475_badges_semantic_colours branch September 21, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Non breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants