KOA-5354 Enable shadowless cards #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,7 +43,7 @@ public struct BPKCard<Content: View>: View { | |||
| } | |||
| } | |||
|
|
|||
| private var elevation: Elevation | |||
| private var elevation: Elevation? | |||
There was a problem hiding this comment.
Is there a specific reason to make the elevation nullable?
If the user doesn't provide an elevation, we will fallback to 'default'.
There was a problem hiding this comment.
I thought about it like if you want no elevation, this could be represented as nil, as a lack of being a shadow.
There was a problem hiding this comment.
I feel it might be better to be explicit about it.
considering:
- Not supplying = .default
- Making it nil = no shadow
- Passing in .none = no shadow
If we make it non nullable, then we fallback to default and people supply .none to hide the shadow.
frugoman
commented
Jun 23, 2022
|
|
||
| extension View { | ||
| @ViewBuilder | ||
| func shadow(_ shadow: BPKShadow?) -> some View { |
There was a problem hiding this comment.
This is internal on purpose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cards without shadow
Given that the apis of SwiftUI and UIKit differ, the solution is different on the 2 systems, with SwiftUI being the preferred one.
Remember to include the following changes:
README.mdBackpack.hheader fileIf you are curious about how we review, please read through the code review guidelines